This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH RFC v2] Add support for non-contiguous memory regions
- From: Nick Clifton <nickc at redhat dot com>
- To: Christophe Lyon <christophe dot lyon at linaro dot org>, binutils <binutils at sourceware dot org>
- Date: Wed, 8 Jan 2020 13:14:16 +0000
- Subject: Re: [PATCH RFC v2] Add support for non-contiguous memory regions
- References: <CAKdteOY8M+aMNh7iozcU2BqL8OpDwCdJs_XF+MBiFj25vkdaoQ@mail.gmail.com>
Hi Christophe,
> There are now 4 patches, to hopefully make review/comments easier:
> * patch1: is the main (code) patch
> * patch2: generic test
> * patch3: arm tests
> * patch4: powerpc test
I think that you need to test some non-ELF based targets. Or maybe a
--enable-targets=all configuration. I am seeing this error when building:
bfd/ecoff.c:81:1: error: missing initializer for field 'already_assigned' of 'asection' {aka 'struct bfd_section'} [-Werror=missing-field-initializers]
Also when adding a new feature like this, it would be nice if you could
include a line or two in ld/NEWS describing what it does. This makes it
easier for me to advertise the feature when announcing a new release...
Also you should add a description of the option to ld/ld.texi.
Cheers
Nick