This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Prefer object over notype symbols when disassembling
- From: "Maciej W. Rozycki" <macro at linux-mips dot org>
- To: Alan Modra <amodra at gmail dot com>
- Cc: Borislav Petkov <bp at suse dot de>, binutils at sourceware dot org, Michael Matz <matz at suse dot de>
- Date: Mon, 6 Jan 2020 14:11:23 +0000 (GMT)
- Subject: Re: Prefer object over notype symbols when disassembling
- References: <20191211160613.28935-1-bp@suse.de> <20191212053735.GU32672@bubble.grove.modra.org> <20191215174854.GB2947@zn.tnic> <20191216055923.GD32672@bubble.grove.modra.org> <20191216161424.GC17408@zn.tnic> <20191217101559.GR32672@bubble.grove.modra.org>
On Tue, 17 Dec 2019, Alan Modra wrote:
> diff --git a/ld/testsuite/ld-mips-elf/eh-frame5.s b/ld/testsuite/ld-mips-elf/eh-frame5.s
> index 741a021685..cf5a11c37a 100644
> --- a/ld/testsuite/ld-mips-elf/eh-frame5.s
> +++ b/ld/testsuite/ld-mips-elf/eh-frame5.s
> @@ -2,6 +2,7 @@
> .cfi_personality 0x0,local_pers
> .cfi_lsda 0x0,LSDA
> .ent f1
> + .type f1, @function
> f1:
> nop
> .end f1
If this and similar changes throughout are required, then we have a bug
somewhere, probably in GAS, because `.ent' is supposed to set STT_FUNCTION
for the symbol named, making a `.type' pseudo-op to do the same redundant.
Cf. `s_mips_ent' and:
symbol_get_bfdsym (symbolP)->flags |= BSF_FUNCTION;
I'd rather keep the old arrangement in the test suite to provide coverage
for this semantics.
Maciej