This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Usage of unitialized heap in tic4x_print_cond


On Sun, Dec 29, 2019 at 05:32:48PM +0100, Tim Rühsen wrote:
> On 29.12.19 12:41, Alan Modra wrote:
> > 	PR 25319
> > 	* tic4x-dis.c (tic4x_print_cond): Init all of condtable.
> > 
> > diff --git a/opcodes/tic4x-dis.c b/opcodes/tic4x-dis.c
> > index d9f95c9410..01cfa1e060 100644
> > --- a/opcodes/tic4x-dis.c
> > +++ b/opcodes/tic4x-dis.c
> > @@ -277,7 +277,7 @@ tic4x_print_cond (struct disassemble_info *info, unsigned int cond)
> >  
> >    if (condtable == NULL)
> >      {
> > -      condtable = xmalloc (sizeof (tic4x_cond_t *) * 32);
> > +      condtable = xcalloc (sizeof (tic4x_cond_t *), 32);
> >        for (i = 0; i < tic4x_num_conds; i++)
> >  	condtable[tic4x_conds[i].cond] = (tic4x_cond_t *)(tic4x_conds + i);
> >      }
> 
> Sorry for being nitpicking, but isn't it xcalloc(nmemb, size) ?

Correct, thanks.  Fixed, not that it matters much.

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]