This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
coff-alpha memory leak
- From: Alan Modra <amodra at gmail dot com>
- To: binutils at sourceware dot org
- Date: Fri, 20 Dec 2019 20:22:26 +1030
- Subject: coff-alpha memory leak
* coff-alpha.c (alpha_ecoff_read_ar_hdr): Free ar_hdr on error return.
diff --git a/bfd/coff-alpha.c b/bfd/coff-alpha.c
index d36921bbfe..fe7fcb143d 100644
--- a/bfd/coff-alpha.c
+++ b/bfd/coff-alpha.c
@@ -2026,7 +2026,10 @@ alpha_ecoff_read_ar_hdr (bfd *abfd)
if (bfd_seek (abfd, (file_ptr) FILHSZ, SEEK_CUR) != 0
|| bfd_bread (ab, (bfd_size_type) 8, abfd) != 8
|| bfd_seek (abfd, (file_ptr) (- (FILHSZ + 8)), SEEK_CUR) != 0)
- return NULL;
+ {
+ free (ret);
+ return NULL;
+ }
ret->parsed_size = H_GET_64 (abfd, ab);
}
--
Alan Modra
Australia Development Lab, IBM