This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] RISC-V: Fix .p2align is not at smallest instruction


Dear Kuan-Lin,

On Thu, Dec 5, 2019 at 10:30 AM Kuan-Lin Chen <kuanlinchentw@gmail.com> wrote:
> About the fixup cross fragments, I think it's ok.
> Because the addend just records the possible range for alignment.
> We just have to be sure the next fragment has the enough space for alignment.

Thanks for your explanation, I'm OK for this now.

I think ideally solution may be like ARM, support the mapping symbol
and do the related works.  But before we supporting these features,
your solution looks good and can cover lots of mixed cases.

However, my review may not help so much at the moment, it is better to
wait for the approvals by Jim, Palmer and Andrew.  At least one of
them.  I think they should be very busy now since last week is
Thanksgiving :)

Thanks and regards
Nelson


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]