This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Commit: Fix unsigned vs signed comparisons in SH code

From: Nick Clifton <nickc at redhat dot com>
To: Tim Rühsen <tim dot ruehsen at gmx dot de>, Andreas Schwab <schwab at linux-m68k dot org>
Cc: binutils at sourceware dot org
Date: Tue, 26 Nov 2019 16:45:03 +0000
Subject: Re: Commit: Fix unsigned vs signed comparisons in SH code
References: <87o8wyivfr.fsf@redhat.com> <87r21ulkli.fsf@igel.home> <af16d608-f99b-8927-0c1f-b12710534b61@gmx.de>

Hi Guys,

>> Why is that a unsigned vs signed comparison?  Both operands are of type
>> bfd_vma.
> 
> You are right, it isn't.
> 
> It is clang-10 (possibly clang-9, but not installed here):
> 
> warning: overlapping comparisons always evaluate to true
> [-Wtautological-overlap-compare]
> 
> So the comparison works likely not as intended.

Right, sorry - I had the wrong description of the warning in my subject line.

Cheers
  Nick

Attachment: signature.asc
Description: OpenPGP digital signature

References:
- Commit: Fix unsigned vs signed comparisons in SH code
  - From: Nick Clifton
- Re: Commit: Fix unsigned vs signed comparisons in SH code
  - From: Andreas Schwab
- Re: Commit: Fix unsigned vs signed comparisons in SH code
  - From: Tim Rühsen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]