Re: [PATCH v2 0/9] ELF support for targets with octets_per_byte>1

[Christian Eggers <ceggers at gmx dot de>]

Dear Alen,

Am Montag, 25. November 2019, 05:39:55 CET schrieb Alan Modra:

> I've committed these as two patches.
thank you very much for spending so much time in repairing my patches.

> We shouldn't commit changes like
> that for bfd_octets_per_byte piecemeal since that would leave the
> source tree broken between patches.
I wasn't sure how to format the inline changelog if the patch spreads over
multiple directories. Now this seems clear for for me.

> Speaking of which, I added some
> necessary changes to include/coff/ti.h.
Unfortunately I didn't realize this although my IDE (Eclipse) showed me this
macros in the call hierarchy. Probably it showed me the wrong location as
several versions of GET_SCNHDR_SIZE() exist at multiple locations.

> I've also fixed a few
> remaining formatting nits, and will make a followup patch to fix a few
> more issues.
Looks like your followup patch was at least the same effort as my patch...

I'll try no to repeat the same mistakes for my next patches.
Btw: Do you think a sending-patches.txt would be useful for binutils?

regards
Christian