This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Commit: Fix potential null pointer dereference in linker

From: Nick Clifton <nickc at redhat dot com>
To: Alan Modra <amodra at gmail dot com>
Cc: binutils at sourceware dot org
Date: Fri, 22 Nov 2019 13:14:02 +0000
Subject: Re: Commit: Fix potential null pointer dereference in linker
References: <87tv6xi2nh.fsf@redhat.com> <20191121230232.GE31415@bubble.grove.modra.org>

Hi Alan,

> Actually, &file_chain.head->input_statement is exactly the same as
> (lang_input_statement_type *) file_chain.head

> Please, can you just go back to using the cast here instead?  A while
> ago I spent quite a bit of effort removing casts in ldlang.* but I
> reckon a cast looks better than this overlong line.

Fair enough.  Done.

Cheers
   Nick

binutils/ChangeLog
2019-11-22  Nick Clifton  <nickc@redhat.com>

	* ldlang.h (LANG_FOR_EACH_INPUT_STATEMENT): Use cast instead of
	extra check.

References:
- Commit: Fix potential null pointer dereference in linker
  - From: Nick Clifton
- Re: Commit: Fix potential null pointer dereference in linker
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]