This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] x86: imply all No_*Suf when none is set in a template
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Jan Beulich <jbeulich at suse dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Thu, 14 Nov 2019 11:26:56 -0800
- Subject: Re: [PATCH] x86: imply all No_*Suf when none is set in a template
- References: <2e594028-7f60-a0b9-086b-269d883c7441@suse.com>
On Thu, Nov 14, 2019 at 12:51 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> Since no template would ever allow for none of them to be set, reduce
> table size and improve readability and hence maintainability by implying
> all of them to be set when a template specifies none.
>
> opcodes/
> 2019-11-XX Jan Beulich <jbeulich@suse.com>
>
> * i386-gen.c (process_i386_opcode_modifier): Widen scope of
> bwlq_suf. New local variable other_suf. Emit warning when all
> No_*Suf are set. Set all No_*Suf when none are set.
> * i386-opc.tbl: Drop No_bSuf, No_wSuf, No_lSuf, No_sSuf,
> No_qSuf, and No_ldSuf when they're all specified at the same
> time.
I don't think it may the table more readable. Why not simply add
#define No_Suf No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf
and use it?
--
H.J.