This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/5] gas: Add md_generic_table_relax_frag


On Tue, Nov 12, 2019 at 8:55 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 12.11.2019 17:19,  H.J. Lu  wrote:
> > --- a/gas/write.c
> > +++ b/gas/write.c
> > @@ -3030,7 +3030,12 @@ relax_segment (struct frag *segment_frag_root, segT segment, int pass)
> >  #ifdef TC_GENERIC_RELAX_TABLE
> >               /* The default way to relax a frag is to look through
> >                  TC_GENERIC_RELAX_TABLE.  */
> > +#ifdef md_generic_table_relax_frag
> > +             growth = md_generic_table_relax_frag (segment, fragP,
> > +                                                   stretch);
> > +#else
> >               growth = relax_frag (segment, fragP, stretch);
> > +#endif /* md_generic_table_relax_frag */
> >  #endif /* TC_GENERIC_RELAX_TABLE  */
> >  #endif
> >               break;
>
> Wouldn't
>
> #ifndef md_generic_table_relax_frag
> #define md_generic_table_relax_frag relax_frag
> #endif
>
> higher up in the file result in somewhat better readable code
> above?
>

Will do.

Thanks.

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]