This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][libiberty] Fix read buffer overflow in split_directories()

From: Orlando Arias <orlandoarias at gmail dot com>
To: binutils at sourceware dot org
Date: Sat, 9 Nov 2019 23:51:19 -0500
Subject: Re: [PATCH][libiberty] Fix read buffer overflow in split_directories()
References: <e542f40a-8f73-7ab7-11af-2c62263a1897@gmx.de>

Greetings

On 11/9/19 6:18 PM, Tim Rühsen wrote:
> In line
>   if (dirs[num_dirs - 1] == NULL)
> 'num_dirs' can be 0.
> 
> Regards, Tim
> 

I've looked at the control-flow on this file and I do not see a possible
path for num_dirs to be 0 at line 186, unless the file name in question
is the empty string "", at which point it may just be easier to return
earlier. Can you please verify this?

Thank you.

Cheers,
Orlando.

Attachment: signature.asc
Description: OpenPGP digital signature

Follow-Ups:
- Re: [PATCH][libiberty] Fix read buffer overflow in split_directories()
  - From: Tim Rühsen

References:
- [PATCH][libiberty] Fix read buffer overflow in split_directories()
  - From: Tim Rühsen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]