This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 02/13] x86: drop ShortForm attribute

Hi,

On Thu, 7 Nov 2019, Jan Beulich wrote:

> > FWIW, whenever I look at that file and see the usual marvel
> > 
> >   No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf
> > 
> > I cringe, and wonder why it isn't simply No_bwlsqldSuf (or, in this 
> > specific case 'No_Suf' as these are all No_?Suf flags).  Now, back to 
> > under my stone :)
> 
> I'd go a more radical (and sufficiently simple) step as a first move:
> No instruction allowing for all suffixes, what about making i386-gen
> simply set all 6 bits when it finds a template to not have any No_*Suf
> at all? This would make for a significant readability improvement with
> relatively little effort. Thoughts?

I'd like that even more.


Ciao,
Michael.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]