This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 1/2] Fix size of dos_message type in internal_extra_pe_filehdr
- From: Andrew Eikum <aeikum at codeweavers dot com>
- To: binutils at sourceware dot org
- Date: Mon, 28 Oct 2019 10:16:34 -0500
- Subject: Re: [PATCH 1/2] Fix size of dos_message type in internal_extra_pe_filehdr
- References: <20191017192652.zqui6gcq7ciqnhnn@foghorn.codeweavers.com>
Hello,
Is there anyone available to review these patches? This problem is
affecting Wine users[1], so I'd love to get a solution into binutils.
Please let me know if there's anything more I can do to help get this
fixed.
[1] https://bugs.winehq.org/show_bug.cgi?id=47718
Thanks for your time,
Andrew
On Thu, Oct 17, 2019 at 02:26:53PM -0500, Andrew Eikum wrote:
> As shown by other declarations in include/coff/, and its usage in
> bfd/peXXigen.c, dos_message is clearly meant to be 64 bytes long. On
> Linux 64-bit, long is 8 bytes, which means the dos_message field in
> internal_extra_pe_filehdr would be 128 bytes long.
>
> Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
> ---
> include/coff/internal.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/coff/internal.h b/include/coff/internal.h
> index c87dc8abaf..6069af972c 100644
> --- a/include/coff/internal.h
> +++ b/include/coff/internal.h
> @@ -54,7 +54,7 @@ struct internal_extra_pe_filehdr
> unsigned short e_oeminfo; /* OEM information; e_oemid specific, 0x0 */
> unsigned short e_res2[10]; /* Reserved words, all 0x0 */
> bfd_vma e_lfanew; /* File address of new exe header, 0x80 */
> - unsigned long dos_message[16]; /* text which always follows dos header */
> + unsigned int dos_message[16]; /* text which always follows dos header */
> bfd_vma nt_signature; /* required NT signature, 0x4550 */
> };
>
> --
> 2.23.0
>
>