This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Commit: Improve gnu build attribute note merging
- From: Alan Modra <amodra at gmail dot com>
- To: Nick Clifton <nickc at redhat dot com>
- Cc: binutils at sourceware dot org
- Date: Sat, 26 Oct 2019 13:11:57 +1030
- Subject: Re: Commit: Improve gnu build attribute note merging
- References: <87y2x825il.fsf@redhat.com>
On Fri, Oct 25, 2019 at 04:45:22PM +0100, Nick Clifton wrote:
> +static int
> +sort_gnu_build_notes (const void * data1, const void * data2)
> +{
> + objcopy_internal_note * pnote1 = (objcopy_internal_note *) data1;
> + objcopy_internal_note * pnote2 = (objcopy_internal_note *) data2;
> +
> + if (pnote1->note.type != pnote2->note.type)
> + {
> + /* Move deleted notes to the end. */
> + if (is_deleted_note (pnote1)) /* 1: OFD 2: OFD */
> + return 1;
> +
> + /* Move OPEN notes to the start. */
> + if (is_open_note (pnote1)) /* 1: OF 2: OFD */
> + return -1;
> +
> + if (is_deleted_note (pnote2)) /* 1: F 2: O D */
> + return 1;
I think you meant to return -1 here. Fix committed.
--
Alan Modra
Australia Development Lab, IBM