This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] x86/Intel: correct MOVSD and CMPSD handling
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Jan Beulich <jbeulich at suse dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Fri, 4 Oct 2019 08:15:17 -0700
- Subject: Re: [PATCH] x86/Intel: correct MOVSD and CMPSD handling
- References: <78d4c121-b563-c41c-9ba8-314653bb25c0@suse.com>
On Fri, Oct 4, 2019 at 12:45 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> First and foremost the EsSeg attribute was misplaced for CMPSD. Then
> both it and MOVSD were lacking Dword on both of their operands.
> Finally string insns with multiple operands and requiring use of ES:
> had the wrong operand number reported in the diagnostic.
>
> gas/
> 2019-10-04 Jan Beulich <jbeulich@suse.com>
>
> * config/tc-i386.c (check_string): Make reported operand number
> depend on Intel syntax.
> * testsuite/gas/i386/intel-cmps.s,
> testsuite/gas/i386/intel-cmps32.d,
> testsuite/gas/i386/intel-cmps64.d: New.
> * testsuite/gas/i386/i386.exp: Run new tests.
> * testsuite/gas/i386/intel-movs.s: Extend.
> * testsuite/gas/i386/intel-movs32.d,
> testsuite/gas/i386/intel-movs64.d: Adjust expectations.
> * testsuite/gas/i386/string-bad.l: Tighten expectations.
>
> opcodes/
> 2019-10-04 Jan Beulich <jbeulich@suse.com>
>
> * opcodes/i386-opc.tbl (movsd): Add Dword and IgnoreSize.
> (cmpsd): Likewise. Move EsSeg to other operand.
> * opcodes/i386-tbl.h: Re-generate.
>
OK.
Thanks.
--
H.J.