This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH v4 00/35] CTF linking support
On Wed, Sep 25, 2019 at 02:59:43PM +0100, Nick Alcock wrote:
> On 25 Sep 2019, Alan Modra uttered the following:
>
> > So I applied this series and the first thing I noticed was a whole lot
> > of "git am" complaints. In my .git/config I have
> > [core]
> > ...
> > whitespace = indent-with-non-tab,space-before-tab,trailing-space
> > to help keep my own patches consistent with how most binutils files
> > are formatted. Please don't introduce more inconsistencies.
>
> These are all from generated code, introduced by Automake: the source
> has no trailing whitespace.
It was indentation with spaces that I particularly noticed. eg. this
one from _bfd_elf_assign_file_positions_for_non_load
- const char *name = sec->name;
+ const char *name = sec->name;
--
Alan Modra
Australia Development Lab, IBM