This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH v4 11/35 CHANGED] libctf: fix double-free on ctf_compress_write error path
- From: Nick Alcock <nick dot alcock at oracle dot com>
- To: binutils at sourceware dot org
- Cc: Nick Alcock <nick dot alcock at oracle dot com>, Hans-Peter Nilsson <hp at bitrange dot com>
- Date: Tue, 24 Sep 2019 14:51:07 +0100
- Subject: [PATCH v4 11/35 CHANGED] libctf: fix double-free on ctf_compress_write error path
- References: <20190924135131.441906-1-nick.alcock@oracle.com>
We were freeing the compressed data buffer twice if compression failed.
v4: Fix commit message.
libctf/
* ctf-create.c (ctf_compress_write): Fix double-free.
---
libctf/ctf-create.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libctf/ctf-create.c b/libctf/ctf-create.c
index 6189042fdb0..76304f724c7 100644
--- a/libctf/ctf-create.c
+++ b/libctf/ctf-create.c
@@ -1997,7 +1997,6 @@ ctf_compress_write (ctf_file_t *fp, int fd)
{
ctf_dprintf ("zlib deflate err: %s\n", zError (rc));
err = ctf_set_errno (fp, ECTF_COMPRESS);
- ctf_free (buf);
goto ret;
}
--
2.23.0.239.g28aa4420fd