This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH][ARM][GAS]:Modify assembler to accept floating and signless datatypes for MVE instruction VLDR.

From: Srinath Parvathaneni <Srinath dot Parvathaneni at arm dot com>
To: "binutils at sourceware dot org" <binutils at sourceware dot org>
Cc: nd <nd at arm dot com>, "nickc at redhat dot com" <nickc at redhat dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>
Date: Mon, 23 Sep 2019 16:59:11 +0000
Subject: [PATCH][ARM][GAS]:Modify assembler to accept floating and signless datatypes for MVE instruction VLDR.
Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GEVi0Ze3Q79Hmz9v/ehyIXWSMt2DuJ8WQkabTBCSqvA=; b=T2yiBt87mFvGTvi0rgMPCDsaBLbNvWyrPP9vcazyqeNXK7J4mS28kI91Tx3riFU34NoZCXDjlaWQ+vNFnOT/abDieYQpgFzSCIw6vSL9+9Z76kY261iVq2QyAfGth8bZOYUGq71l5CSl82bfRc6tWJ5xT/it9Dlu3OLnsqiSn38BH/bBESq8gjyI09rqwIFKCuh+Z8Rj++VKzg/m4qOCsgMo9CaAjS348q/iBcc+UG7PyxApuX/iGjwG5Xp6cAmE5coAVPvf6Qzn6Xv4h3vmkMQaxBAAOe/YHLIqjfJA/v1+zcTzPWijetNnY+mH2KoUD0tM51fRZ7H8mTMURbSb3A==
Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=djHvDHycsxDJZy6Se9zYUc5TabaUdL5gjhzD3fpFsQr0tGt/z6u/Vx1r/tzs5RoejvLHbpYOLxO6H0wUfAvD6LHsiBklvxF2DNu+ID0QSaNMIr4GaS476ukFtO9orIPrKFUZAoJ0jsRQ2JojvJXuoqjV8DtLCNdLyBgnZRvdHhpV+Tn1ukaxRFLH/UZ51ik6f7BTSZsub5Yo0frN2mu6vC4Zq8Pmt7fFOrP+60F+2vJgLXBb00bxUfPM3muzmvop8qkHUlPpKzbfEJ7KgOMACUqQLcGm2+u0mWDxQDP9R+kI9SofI4YLXrfzbJlioVfJtjPSgv1bG5NLEdG0VntYhg==
Original-authentication-results: spf=none (sender IP is ) smtp.mailfrom=Srinath dot Parvathaneni at arm dot com;

Hello,

This patch modifies assembler to accept the equivalent sized floating and signless datatypes
for VLDR instruction but as alias for the unsigned version.

Example:
$cat test.s
VLDRH.f16 q0, [r2, q3, uxtw #1]
VLDRH.16 q0, [r2, q3, uxtw #1]
VLDRH.p16 q0, [r2, q3, uxtw #1]

Assembler without this patch:
$ arm-none-eabi-as test.s -march=armv8.1-m.main+mve.fp -mfloat-abi=hard
test.s: Assembler messages:
test.s:1: Error: bad element type for instruction -- `vldrh.f16 q0,[r2,q3,uxtw#1]'
test.s:2: Error: bad element type for instruction -- `vldrh.16 q0,[r2,q3,uxtw#1]'
test.s:3: Error: bad element type for instruction -- `vldrh.p16 q0,[r2,q3,uxtw#1]'


Assembler and Disassembler with this patch:
$ arm-none-eabi-as test.s -march=armv8.1-m.main+mve.fp -mfloat-abi=hard -o test.o

$ arm-none-eabi-objdump -marmv8.1-m.main -dr test.o

Disassembly of section .text:
00000000 <.text>:
   0:	fc92 0e97 	vldrh.u16	q0, [r2, q3, uxtw #1]
   4:	fc92 0e97 	vldrh.u16	q0, [r2, q3, uxtw #1]
   8:	fc92 0e97 	vldrh.u16	q0, [r2, q3, uxtw #1]

Assembler accepts all the instructions in test.s as valid, but disassembles them as vldrh.u16 (unsigned datatype with size 16).

For more details about the above mentioned instructions please refer to latest arm architecture reference manual [1].

[1] https://developer.arm.com/architectures/cpu-architecture/m-profile/docs/ddi0553/latest/armv81-m-architecture-reference-manual

Bootstrapped on arm-none-linux-gnueabihf and regression tested on arm-none-eabi with no regressions.

Ok for master?

gas ChangeLog:

2019-09-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>

	* config/tc-arm.c (do_mve_vstr_vldr_RQ): Modify function to allow float
	* and signless datatypes for few cases of VLDR instruction.
	* testsuite/gas/arm/mve-vldr-bad-3.l: Modify.
	* testsuite/gas/arm/mve-vldr-bad-3.s: Likewise.
	* testsuite/gas/arm/mve-vstrldr-1.d: Likewise.
	* testsuite/gas/arm/mve-vstrldr-1.s: Likewise.


###############     Attachment also inlined for ease of reply    ###############


diff --git a/gas/config/tc-arm.c b/gas/config/tc-arm.c
index 7760d1807d3599690d1ee8cdfcdc90f547699605..2f394bae505f202e615ebcac6c19097ac4d51ac6 100644
--- a/gas/config/tc-arm.c
+++ b/gas/config/tc-arm.c
@@ -17282,6 +17282,7 @@ static void
 do_mve_vstr_vldr_RQ (int size, int elsize, int load)
 {
     unsigned os = inst.operands[1].imm >> 5;
+    unsigned type = inst.vectype.el[0].type;
     constraint (os != 0 && size == 8,
 		_("can not shift offsets when accessing less than half-word"));
     constraint (os && os != neon_logbits (size),
@@ -17312,15 +17313,14 @@ do_mve_vstr_vldr_RQ (int size, int elsize, int load)
 	constraint (inst.operands[0].reg == (inst.operands[1].imm & 0x1f),
 		    _("destination register and offset register may not be"
 		    " the same"));
-	constraint (size == elsize && inst.vectype.el[0].type != NT_unsigned,
+	constraint (size == elsize && type == NT_signed, BAD_EL_TYPE);
+	constraint (size != elsize && type != NT_unsigned && type != NT_signed,
 		    BAD_EL_TYPE);
-	constraint (inst.vectype.el[0].type != NT_unsigned
-		    && inst.vectype.el[0].type != NT_signed, BAD_EL_TYPE);
-	inst.instruction |= (inst.vectype.el[0].type == NT_unsigned) << 28;
+	inst.instruction |= ((size == elsize) || (type == NT_unsigned)) << 28;
       }
     else
       {
-	constraint (inst.vectype.el[0].type != NT_untyped, BAD_EL_TYPE);
+	constraint (type != NT_untyped, BAD_EL_TYPE);
       }
 
     inst.instruction |= 1 << 23;
diff --git a/gas/testsuite/gas/arm/mve-vldr-bad-3.l b/gas/testsuite/gas/arm/mve-vldr-bad-3.l
index 024822ded3e66ba41b52fa20b13f2e5a3f20069a..4b773b109ebc9ccd7301e3891f1fb97487ddd085 100644
--- a/gas/testsuite/gas/arm/mve-vldr-bad-3.l
+++ b/gas/testsuite/gas/arm/mve-vldr-bad-3.l
@@ -133,3 +133,37 @@
 [^:]*:134: Error: syntax error -- `vldrweq.32 q0,\[r0\]'
 [^:]*:135: Error: vector predicated instruction should be in VPT/VPST block -- `vldrwt.32 q0,\[r0\]'
 [^:]*:137: Error: instruction missing MVE vector predication code -- `vldrw.32 q0,\[r0\]'
+[^:]*:140: Error: bad element type for instruction -- `vldrb.16 q0,\[r2,q3\]'
+[^:]*:140: Error: bad element type for instruction -- `vldrb.32 q0,\[r2,q3\]'
+[^:]*:140: Error: bad element type for instruction -- `vldrb.64 q0,\[r2,q3\]'
+[^:]*:140: Error: bad element type for instruction -- `vldrb.f16 q0,\[r2,q3\]'
+[^:]*:140: Error: bad element type for instruction -- `vldrb.f32 q0,\[r2,q3\]'
+[^:]*:140: Error: bad element type for instruction -- `vldrb.f64 q0,\[r2,q3\]'
+[^:]*:140: Error: bad element type for instruction -- `vldrb.p16 q0,\[r2,q3\]'
+[^:]*:140: Error: bad element type for instruction -- `vldrb.p32 q0,\[r2,q3\]'
+[^:]*:140: Error: bad element type for instruction -- `vldrb.p64 q0,\[r2,q3\]'
+[^:]*:140: Error: bad element type for instruction -- `vldrb.s8 q0,\[r2,q3\]'
+[^:]*:143: Error: bad element type for instruction -- `vldrh.8 q0,\[r2,q3,uxtw#1\]'
+[^:]*:143: Error: bad element type for instruction -- `vldrh.32 q0,\[r2,q3,uxtw#1\]'
+[^:]*:143: Error: bad element type for instruction -- `vldrh.64 q0,\[r2,q3,uxtw#1\]'
+[^:]*:143: Error: bad element type for instruction -- `vldrh.f32 q0,\[r2,q3,uxtw#1\]'
+[^:]*:143: Error: bad element type for instruction -- `vldrh.f64 q0,\[r2,q3,uxtw#1\]'
+[^:]*:143: Error: bad element type for instruction -- `vldrh.p32 q0,\[r2,q3,uxtw#1\]'
+[^:]*:143: Error: bad element type for instruction -- `vldrh.p64 q0,\[r2,q3,uxtw#1\]'
+[^:]*:143: Error: bad element type for instruction -- `vldrh.s16 q0,\[r2,q3,uxtw#1\]'
+[^:]*:146: Error: bad element type for instruction -- `vldrw.8 q0,\[r2,q3,uxtw#2\]'
+[^:]*:146: Error: bad element type for instruction -- `vldrw.16 q0,\[r2,q3,uxtw#2\]'
+[^:]*:146: Error: bad element type for instruction -- `vldrw.64 q0,\[r2,q3,uxtw#2\]'
+[^:]*:146: Error: bad element type for instruction -- `vldrw.f16 q0,\[r2,q3,uxtw#2\]'
+[^:]*:146: Error: bad element type for instruction -- `vldrw.f64 q0,\[r2,q3,uxtw#2\]'
+[^:]*:146: Error: bad element type for instruction -- `vldrw.p16 q0,\[r2,q3,uxtw#2\]'
+[^:]*:146: Error: bad element type for instruction -- `vldrw.p64 q0,\[r2,q3,uxtw#2\]'
+[^:]*:146: Error: bad element type for instruction -- `vldrw.s32 q0,\[r2,q3,uxtw#2\]'
+[^:]*:149: Error: bad element type for instruction -- `vldrd.8 q0,\[r2,q3,uxtw#3\]'
+[^:]*:149: Error: bad element type for instruction -- `vldrd.16 q0,\[r2,q3,uxtw#3\]'
+[^:]*:149: Error: bad element type for instruction -- `vldrd.32 q0,\[r2,q3,uxtw#3\]'
+[^:]*:149: Error: bad element type for instruction -- `vldrd.f16 q0,\[r2,q3,uxtw#3\]'
+[^:]*:149: Error: bad element type for instruction -- `vldrd.f32 q0,\[r2,q3,uxtw#3\]'
+[^:]*:149: Error: bad element type for instruction -- `vldrd.p16 q0,\[r2,q3,uxtw#3\]'
+[^:]*:149: Error: bad element type for instruction -- `vldrd.p32 q0,\[r2,q3,uxtw#3\]'
+[^:]*:149: Error: bad element type for instruction -- `vldrd.s64 q0,\[r2,q3,uxtw#3\]'
diff --git a/gas/testsuite/gas/arm/mve-vldr-bad-3.s b/gas/testsuite/gas/arm/mve-vldr-bad-3.s
index 3b3fd61007457896b9086c4591029670b4ec34b3..3712cada977b290dfa08b3861f11689294299571 100644
--- a/gas/testsuite/gas/arm/mve-vldr-bad-3.s
+++ b/gas/testsuite/gas/arm/mve-vldr-bad-3.s
@@ -135,4 +135,15 @@ vldrweq.32 q0, [r0]
 vldrwt.32 q0, [r0]
 vpst
 vldrw.32 q0, [r0]
-
+.irp op1, 16, 32, 64, f16, f32, f64, p16, p32, p64, s8
+vldrb.\op1 q0, [r2, q3]
+.endr
+.irp op1, 8, 32, 64, f32, f64, p32, p64, s16
+vldrh.\op1 q0, [r2, q3, uxtw #1]
+.endr
+.irp op1, 8, 16, 64, f16, f64, p16, p64, s32
+vldrw.\op1 q0, [r2, q3, uxtw #2]
+.endr
+.irp op1, 8, 16, 32, f16, f32, p16, p32, s64
+vldrd.\op1 q0, [r2, q3, uxtw #3]
+.endr
diff --git a/gas/testsuite/gas/arm/mve-vstrldr-1.d b/gas/testsuite/gas/arm/mve-vstrldr-1.d
index ca3d97c53c30ab720e4c5ef28a7e5829101f48f2..0bffd2e076956a2b72d70192391587f53b5a8cca 100644
--- a/gas/testsuite/gas/arm/mve-vstrldr-1.d
+++ b/gas/testsuite/gas/arm/mve-vstrldr-1.d
@@ -7561,3 +7561,20 @@ Disassembly of section .text:
 [^>]*> fe71 8f4d 	vpste
 [^>]*> fc93 6fdb 	vldrdt.u64	q3, \[r3, q5, uxtw #3\]
 [^>]*> fc97 efd9 	vldrde.u64	q7, \[r7, q4, uxtw #3\]
+[^>]*> fc92 0e06 	vldrb.u8	q0, \[r2, q3\]
+[^>]*> ec92 0e86 	vldrb.s16	q0, \[r2, q3\]
+[^>]*> fc92 0e06 	vldrb.u8	q0, \[r2, q3\]
+[^>]*> fc92 0e97 	vldrh.u16	q0, \[r2, q3, uxtw #1\]
+[^>]*> fc92 0e97 	vldrh.u16	q0, \[r2, q3, uxtw #1\]
+[^>]*> ec92 0f17 	vldrh.s32	q0, \[r2, q3, uxtw #1\]
+[^>]*> fc92 0e97 	vldrh.u16	q0, \[r2, q3, uxtw #1\]
+[^>]*> fc92 0e97 	vldrh.u16	q0, \[r2, q3, uxtw #1\]
+[^>]*> fc92 0f17 	vldrh.u32	q0, \[r2, q3, uxtw #1\]
+[^>]*> fc92 0f47 	vldrw.u32	q0, \[r2, q3, uxtw #2\]
+[^>]*> fc92 0f47 	vldrw.u32	q0, \[r2, q3, uxtw #2\]
+[^>]*> fc92 0f47 	vldrw.u32	q0, \[r2, q3, uxtw #2\]
+[^>]*> fc92 0f47 	vldrw.u32	q0, \[r2, q3, uxtw #2\]
+[^>]*> fc92 0fd7 	vldrd.u64	q0, \[r2, q3, uxtw #3\]
+[^>]*> fc92 0fd7 	vldrd.u64	q0, \[r2, q3, uxtw #3\]
+[^>]*> fc92 0fd7 	vldrd.u64	q0, \[r2, q3, uxtw #3\]
+[^>]*> fc92 0fd7 	vldrd.u64	q0, \[r2, q3, uxtw #3\]
diff --git a/gas/testsuite/gas/arm/mve-vstrldr-1.s b/gas/testsuite/gas/arm/mve-vstrldr-1.s
index 3911216ae546aa46b558bd2c24fe3e35d694e401..d6d11cc8262e065b1e2d7e0bbadbd6628eed0471 100644
--- a/gas/testsuite/gas/arm/mve-vstrldr-1.s
+++ b/gas/testsuite/gas/arm/mve-vstrldr-1.s
@@ -116,3 +116,16 @@ vldrde.u64 q2, [r0, q1]
 vpste
 vldrdt.u64 q3, [r3, q5, UXTW #3]
 vldrde.u64 q7, [r7, q4, UXTW #3]
+
+.irp dt, u8, s16, 8
+vldrb.\dt q0, [r2, q3]
+.endr
+.irp dt, 16, u16, s32, f16, p16, u32
+vldrh.\dt q0, [r2, q3, UXTW #1]
+.endr
+.irp dt, 32, u32, f32, p32
+vldrw.\dt q0, [r2, q3, UXTW #2]
+.endr
+.irp dt, 64, u64, f64, p64
+vldrd.\dt q0, [r2, q3, UXTW #3]
+.endr

Attachment: rb11860.patch
Description: rb11860.patch

Follow-Ups:
- Re: [PATCH][ARM][GAS]:Modify assembler to accept floating and signless datatypes for MVE instruction VLDR.
  - From: Nick Clifton

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]