This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH][Binutils][AArch64] Fix objdump tests
- From: Tamar Christina <Tamar dot Christina at arm dot com>
- To: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Cc: nd <nd at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>
- Date: Tue, 17 Sep 2019 17:42:25 +0000
- Subject: [PATCH][Binutils][AArch64] Fix objdump tests
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YEKDBz5MA11g8IXJsW5dDvADecHjNTgy2n5d+rErgkI=; b=iczF5l9y3tb/JDB9bcWrlvTfdffWTtizCCTIgqdzjrWBCBRMEuZSBKYriXcXj5ViJifIRtiEXkht+rLdz8sBGz/KTx+xHRUjcSbfnAid+upaNmwuPgHeqYW8rdYEpiq88Phy6HcONJVeuxjKSS/7ccPXY37HmS/P2hZ7e272u4mDVM5JNN2/1SdMuloRSgovdZElRPqs1Ews7Zc6MDjgkiHJscKfQzYAaG0uo4uSWgv49Iyey0sLMNXsXaIhP4aHknRj6aSrRG+8gemFsAjSS+L5TXVOdV2rCs6ivi+oM7nOCdp5tqEZmTsXlSGUveiR539oxFvH7IfahjJYL4oNQA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aQMzHG8xe3hHEhW2SQJUf/0X+leD2ucanX2Vt9t8VpL7NFA9cTT+R5iWBHspZLgsvWiT0sXnxknb0ttGu77oEd81QlyNinZjCaZWx/o8VNqEyg3K1PFqkC8mrxoDRkyUYVmJaMsIRSmWddb1RQVB/qhIdmWs5XhRrxF1AuHnpmOK77emTbppKT7Xkb/0ihQ7f0ZQZSq1TDtQV09ikZkYRDJd0ECNIEAF2jIvL1mznEgNa8wg3AkLUcbEWAd1NiusvmeRtOpHdz1P0PXOrwcsyMrZKsckulHnaFcPiJb3psmYcqU63Z9jaoS/N5nTjQlqjtc6YxhSc0YnSuDxg3ZqcA==
- Original-authentication-results: spf=none (sender IP is ) smtp.mailfrom=Tamar dot Christina at arm dot com;
Hi All,
The newly added objdump -S tests check for source line mapping of a static
variable. But the test doesn't dump any data sections so this should never
pass.
This changes the test to dump all sections so the source mapping can be found.
build on native hardware and regtested on
aarch64-none-elf, aarch64-none-elf (32 bit host),
aarch64-none-linux-gnu, aarch64-none-linux-gnu (32 bit host)
Cross-compiled and regtested on
aarch64-none-linux-gnu, aarch64_be-none-linux-gnu
and no issues.
Committed to master under the obvious rule.
Is this OK for backport to binutils-2.33?
Thanks,
Tamar
binutils/ChangeLog:
2019-09-17 Tamar Christina <tamar.christina@arm.com>
* testsuite/binutils-all/objdump.exp: Update testcase.
--
diff --git a/binutils/testsuite/binutils-all/objdump.exp b/binutils/testsuite/binutils-all/objdump.exp
index 9630bacb9053a750cedfdfaf0ded8bd6c424299e..58b66d4bb608f793808acca9dea0a1a0f26fb2e4 100644
--- a/binutils/testsuite/binutils-all/objdump.exp
+++ b/binutils/testsuite/binutils-all/objdump.exp
@@ -818,7 +818,7 @@ proc test_objdump_S { } {
return
}
- set got [binutils_run $OBJDUMP "$OBJDUMPFLAGS -S tmpdir/testprog"]
+ set got [binutils_run $OBJDUMP "$OBJDUMPFLAGS -D -S tmpdir/testprog"]
set want "static int local = 2"
@@ -830,7 +830,7 @@ proc test_objdump_S { } {
set test "objdump --source-comment"
- set got [binutils_run $OBJDUMP "$OBJDUMPFLAGS --source-comment=// tmpdir/testprog"]
+ set got [binutils_run $OBJDUMP "$OBJDUMPFLAGS --disassemble-all --source-comment=// tmpdir/testprog"]
set want "//static int local = 2"