This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH v4] RISC-V: Gate opcode tables by enum rather than string
- From: Jim Wilson <jimw at sifive dot com>
- To: Kito Cheng <kito dot cheng at gmail dot com>
- Cc: Maxim Blinov <maxim dot blinov at embecosm dot com>, Binutils <binutils at sourceware dot org>
- Date: Tue, 3 Sep 2019 18:02:02 -0700
- Subject: Re: [PATCH v4] RISC-V: Gate opcode tables by enum rather than string
- References: <20190829093614.13828-1-maxim.blinov@embecosm.com> <20190829100934.30993-1-maxim.blinov@embecosm.com> <CA+yXCZC7PCd6ALgN9YE22SSr0=tK80_s_HU0AmzFOYEXrWrQiQ@mail.gmail.com>
On Mon, Sep 2, 2019 at 11:14 PM Kito Cheng <kito.cheng@gmail.com> wrote:
> I've tested that with regression in riscv-gnu-toolchain, LGTM :)
Thanks for testing it. This looks good to me too. We lost the
ChangeLog entry, and I noticed two very minor comment typos I missed
on the earlier review, "atleast" should be "at least" and "belongs.
Used" should be "belongs. Used" as coding conventions call for two
spaces after a period. I'm happy to fix this stuff myself and commit
the patch.
There is another issue here though which is that the binutils-2.33
branch is scheduled for Sept 7, and this isn't a bug fix, it is
preparation for adding new features. Do we want to include this now?
Or should we wait until after the branch?
Jim