This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 1/2] [ARC] Update ARC opcode table
- From: claziss at gmail dot com
- To: Simon Marchi <simon dot marchi at efficios dot com>, binutils at sourceware dot org
- Date: Fri, 30 Aug 2019 11:36:53 +0300
- Subject: Re: [PATCH 1/2] [ARC] Update ARC opcode table
- References: <20190724135259.30063-1-claziss@gmail.com> <07465e6c-40e2-4eb6-f8c6-77823a3ec543@efficios.com>
Hi Simon,
Indeed was an issue. Fixed (and pushed) by the attached commit.
Thank you,
Claudiu
On Sun, 2019-08-25 at 18:25 -0400, Simon Marchi wrote:
> On 2019-07-24 9:52 a.m., Claudiu Zissulescu wrote:
> > Update ARC opcode table by cleaning up invalid instructions, and fixing
> > wrong encodings.
>
> Hi Claudiu,
>
> This commit causes these errors when compiling with clang:
>
> /home/smarchi/src/binutils-gdb/opcodes/arc-tbl.h:7633:87: error: implicit
> conversion from enumeration type 'insn_class_t' to different enumeration type
> 'insn_subclass_t' [-Werror,-Wenum-conversion]
> { "fmp_adds", 0x3E227FBE, 0xFFFF7FFF, ARC_OPCODE_ARCv2EM | ARC_OPCODE_ARCv2HS,
> ARITH, FASTMATH, { ZA, LIMM, LIMMdup }, { C_F }},
>
> Is it expected that we put an insn_class_t (FASTMATH) in an insn_subclass_t
> field?
>
> Simon
From cd18a823d1ad0787cb0745bf71c7ba447db10c58 Mon Sep 17 00:00:00 2001
From: Claudiu Zissulescu <claziss@gmail.com>
Date: Fri, 30 Aug 2019 11:31:19 +0300
Subject: [PATCH] [ARC] [COMMITTED] Fix FASTMATH field.
Move FASTMATH to the right enum.
2019-08-30 Claudiu Zissulescu <claziss@gmail.com>
* opcode/arc.h (FASTMATH): Move it from insn_class_t to
insn_subclass_t enum.
---
include/ChangeLog | 5 +++++
include/opcode/arc.h | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/include/ChangeLog b/include/ChangeLog
index e779c17702..3055551062 100644
--- a/include/ChangeLog
+++ b/include/ChangeLog
@@ -1,3 +1,8 @@
+2019-08-30 Claudiu Zissulescu <claziss@gmail.com>
+
+ * opcode/arc.h (FASTMATH): Move it from insn_class_t to
+ insn_subclass_t enum.
+
2019-08-22 Alan Modra <amodra@gmail.com>
* elf/arm.h (ARM_GET_SYM_CMSE_SPCL, ARM_SET_SYM_CMSE_SPCL): Delete.
diff --git a/include/opcode/arc.h b/include/opcode/arc.h
index 14654b5d6c..d6a2b885a1 100644
--- a/include/opcode/arc.h
+++ b/include/opcode/arc.h
@@ -59,7 +59,6 @@ typedef enum
EI,
ENTER,
FLOAT,
- FASTMATH,
INVALID,
JLI,
JUMP,
@@ -99,6 +98,7 @@ typedef enum
DP = (1U << 6),
DPA = (1U << 7),
DPX = (1U << 8),
+ FASTMATH = (1U << 23),
LL64 = (1U << 9),
MPY1E = (1U << 10),
MPY6E = (1U << 11),
--
2.21.0