This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] x86-64: Move PIC check for PC-relative relocations back
- From: Stephen Crane <sjc at immunant dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Fri, 16 Aug 2019 15:22:44 -0700
- Subject: Re: [PATCH] x86-64: Move PIC check for PC-relative relocations back
- References: <CAMe9rOrr=skUmoe4gGar_ub8NqDe71VMPtj34DWEDi4i6En-Aw@mail.gmail.com> <CAMe9rOrO62nuvbDb-dNU68rGiK_Tru_96nXeQmu4xCiEX-UqUg@mail.gmail.com>
Perfect, thank you very much!
On Fri, Aug 16, 2019 at 2:27 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> On Thu, Aug 15, 2019 at 3:02 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> > commit 83924b3846361f2f76f9a6e7b5afa01c0eebbd4f
> > Author: H.J. Lu <hjl.tools@gmail.com>
> > Date: Tue Feb 5 18:45:23 2019 -0800
> >
> > x86-64: Restore PIC check for PCREL reloc against protected symbol
> >
> > moved PIC check for PC-relative relocations to elf_x86_64_check_relocs.
> > Since linker defined symbols may not be processed at the time, we need
> > to move the back to elf_x86_64_relocate_section.
> >
> > bfd/
> >
> > PR ld/24905
> > * elf64-x86-64.c (elf_x86_64_check_relocs): Move PIC check for
> > PC-relative relocations back to ...
> > (elf_x86_64_relocate_section): Here.
> >
> > ld/testsuite/
> >
> > PR ld/24905
> > * ld-x86-64/pr24905-x32.d: New file.
> > * ld-x86-64/pr24905.d: Likewise.
> > * ld-x86-64/pr24905.s: Likewise.
> > * ld-x86-64/pr24905.t: Likewise.
> > * testsuite/ld-x86-64/x86-64.exp: Run pr24905 and pr24905-x32.
> >
>
> I will backport it to release branch later.
>
> --
> H.J.
>