This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][ARM][BINUTILS] Modification to arm encoding and decoding of SQRSHRL and UQRSHLL MVE instructions.

From: Simon Richter <Simon dot Richter at hogyros dot de>
To: binutils at sourceware dot org
Date: Mon, 12 Aug 2019 19:12:54 +0200
Subject: Re: [PATCH][ARM][BINUTILS] Modification to arm encoding and decoding of SQRSHRL and UQRSHLL MVE instructions.
References: <DBBPR08MB477500C2C8B4A8477167ADCD9BD30@DBBPR08MB4775.eurprd08.prod.outlook.com>

Hi,

> +#define po_imm1_or_imm2_or_fail(imm1, imm2, popt)		\
[...]
> +      if (exp.X_add_number != imm1 && exp.X_add_number != imm2) \
> +	{							\
> +	  inst.error = _("immediate value 48 or 64 expected");	\

This might be problematic if anyone ever reuses this code for other
constants, but I can't see an obvious solution that will still be
translateable.

   Simon

References:
- [PATCH][ARM][BINUTILS] Modification to arm encoding and decoding of SQRSHRL and UQRSHLL MVE instructions.
  - From: Srinath Parvathaneni

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]