This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] xtensa: bfd: add special case to loop alignment check
- From: "augustine dot sterling at gmail dot com" <augustine dot sterling at gmail dot com>
- To: Max Filippov <jcmvbkbc at gmail dot com>
- Cc: binutils at sourceware dot org, Eric Tsai <erictsai at cadence dot com>, linux-xtensa at linux-xtensa dot org
- Date: Wed, 31 Jul 2019 11:20:02 -0700
- Subject: Re: [PATCH] xtensa: bfd: add special case to loop alignment check
- References: <20190731072227.14893-1-jcmvbkbc@gmail.com>
On Wed, Jul 31, 2019 at 12:22 AM Max Filippov <jcmvbkbc@gmail.com> wrote:
>
> check_loop_aligned is used during link time relaxation to only allow
> transformations that don't violate loop body alignment requirements.
> Assembler can relax loops that have too long body by adding instructions
> between the loop instruction and the loop body. check_loop_aligned must
> check alignment of the first instruction of the actual loop body.
> Detect loop / rsr.lend / wsr.lbeg sequence used in assembly time
> relaxation and adjust alignment check when it's detected.
Approved. I'm surprised no one has noticed this until now.