This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [PATCH][binutils][AArch64][3/3] Add support for float16 (IEEE format) for AArch64 backend.
- From: Tamar Christina <Tamar dot Christina at arm dot com>
- To: Barnaby Wilks <Barnaby dot Wilks at arm dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Cc: nd <nd at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>
- Date: Wed, 24 Jul 2019 11:12:19 +0000
- Subject: RE: [PATCH][binutils][AArch64][3/3] Add support for float16 (IEEE format) for AArch64 backend.
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=arm.com;dmarc=pass action=none header.from=arm.com;dkim=pass header.d=arm.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=btXoQabhp6vRIxdHOPBuAVYuZOuTRolapRGezmEeKeQ=; b=c24MX9DLkTQF+A92cc02+pT6DtimlogbO7COgncZ9uh0/UOhVfwOQa8JzhPzCVES1CA31/qhF/Ec2lbB3Df+kpyqeXgMXMciZrDKrKt+e+EBYhVeeFs56EviK4MMO6JrwdVGV8o1k85cJASmsQFr9quLuPhjVU3w1Fjv2LpqrA+qCc0PYjXZYZMY4ToBVwuqRXY7uCLjMWOFWkLT9rGPHcx4eM+Tv2XzD5+AjpOLLOaksD+zKdovb1r48cfP2sAP+zhHYyFiXTkvbnekELQE64FMZwC1a/gcCALC8jdW6vN2ptEQnj+G6/GeWmS8wMFWYp+HPdLvvEWakvAi9LP8iw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NMRQGT7RvmKi4VzsXq/MZEIxkn7xJ2ivSlS8ijuBVVjnHac8AXVwb/k5g9Pj+RRTAiUVdaD1KmoFNwy9rR9O0MSpXdyAjgfuHerQq2gNweNLr3+HkGLFnmULb9qKf7IrBj7o97nhBR670qLXcL0qThB7XQkOHKew0dMQUy41Yj8mNdryW/hB/SQ38ljrEy9BITFUrzEcB9hwkliHjw+WO1MKzM9KGWki50KGXXrqc9EozpnoXVyMtIr/e5JbCCoW/CCF1FXkh5v5mvroTmDdrwC14bEObFadoBGPPgIozHI3iLp2hZ7cW1EcJlXlwZcRJsJRUTBy6MQure0XQlii1g==
- References: <bf60fccd-0268-43e9-5cea-343649acb733@arm.com> <ae75487d-8008-b1f6-3d00-952cf9b256e0@arm.com>
Hi Barnaby,
Thanks for the patch!
Your float16-le.s and float-16-be.s look identical to me. Could you delete one and rename it to float16.s and use that as the source for both.
Also could you add a NEWS entry for both these and the AArch32 patches.
Thanks,
Tamar
> -----Original Message-----
> From: binutils-owner@sourceware.org <binutils-owner@sourceware.org> On
> Behalf Of Barnaby Wilks
> Sent: Thursday, July 11, 2019 16:27
> To: binutils@sourceware.org
> Cc: nd <nd@arm.com>; Richard Earnshaw <Richard.Earnshaw@arm.com>;
> Marcus Shawcroft <Marcus.Shawcroft@arm.com>
> Subject: [PATCH][binutils][AArch64][3/3] Add support for float16 (IEEE
> format) for AArch64 backend.
>
> Hello,
>
> This is part of a patch series that implements a directive for
> assembling 16-bit floating point constants for Arm and AArch64.
>
> This patch implements a float16 directive for assembling 16 bit IEEE
> 754 floating point numbers for AArch64.
>
> The syntax of the directive is:
> .float16 <0-n decimal numbers>
> e.g.
> .float16 0.5
> .float16 10.2, NaN, 452.09
>
> The floats will always be encoded using the binary16 format as
> described in the IEEE 754-2008 standard. There is no need to support
> Arm's alternative half-precision format since AArch64 only supports the IEEE format.
>
> Added testcases to verify the correct encoding (for big and little
> endian
> targets) and cross-referenced the encodings with GCC's __fp16 type to
> ensure consistency.
>
> Cross compiled and regtested on aarch64-none-elf and
> aarch64-none-linux- gnu with no issues.
>
> I don't have write access, so if it's OK then could someone commit on
> my behalf?
>
> Thanks,
> Barney
>
> gas/ChangeLog:
>
> 2019-07-11 Barnaby Wilks<barnaby.wilks@arm.com>
>
> * config/tc-aarch64.c: Add float16 directive and add "Hh" to
> acceptable float
> characters.
> * testsuite/gas/aarch64/float16-be.d: New test.
> * testsuite/gas/aarch64/float16-be.s: New test.
> * testsuite/gas/aarch64/float16-le.d: New test.
> * testsuite/gas/aarch64/float16-le.s: New test.