This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Remove tests that test __gnu_lto_v1 symbol.
On 7/23/19 5:59 PM, H.J. Lu wrote:
> On Tue, Jul 23, 2019 at 8:43 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>>
>> On Mon, Jul 22, 2019 at 6:02 AM Martin Liška <mliska@suse.cz> wrote:
>>>
>>> Hi.
>>>
>>> As of r273662, the GCC compiler stopped emitting __gnu_lto_v1 symbol
>>> for LTO objects.
>>>
>>> Thus I'm suggesting to remove the tests for it.
>>>
>>> Ready for trunk?
>>> Thanks,
>>> Martin
>>>
>>> ld/ChangeLog:
>>>
>>> 2019-07-22 Martin Liska <mliska@suse.cz>
>>>
>>> * testsuite/ld-plugin/lto-3r.d: Remove.
>>> * testsuite/ld-plugin/lto-5r.d: Remove.
>>> * testsuite/ld-plugin/lto.exp: Do not run lto-3r and lto-5r
>>> tests.
>>> ---
>>> ld/testsuite/ld-plugin/lto-3r.d | 7 -------
>>> ld/testsuite/ld-plugin/lto-5r.d | 7 -------
>>> ld/testsuite/ld-plugin/lto.exp | 6 ------
>>> 3 files changed, 20 deletions(-)
>>> delete mode 100644 ld/testsuite/ld-plugin/lto-3r.d
>>> delete mode 100644 ld/testsuite/ld-plugin/lto-5r.d
>>>
>>>
>>
>> This caused:
>>
>> FAIL: LTO 5 symbol
>> FAIL: LTO 3b
>> FAIL: LTO 5
>>
>> cc: error: tmpdir/lto-5.o: No such file or directory
>> cc: error: tmpdir/lto-5.o: No such file or directory
>> Unexpected linker warning or error
>> FAIL: LTO 5 symbol
>>
>
> This patch fixes it. OK for master?
>
>
Thank you for the patch, it looks fine to me.
Martin