This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Define ELF_OSABI for visium
- From: Alan Modra <amodra at gmail dot com>
- To: binutils at sourceware dot org
- Date: Wed, 24 Jul 2019 16:09:59 +0930
- Subject: Define ELF_OSABI for visium
and update expected results for gas mbind tests.
bfd/
* elf32-visium.c (visium_elf_post_process_headers): Don't set
EI_OSABI header byte here.
(ELF_OSABI): Define.
gas/
* testsuite/gas/elf/section12a.d: xfail visium and cloudabi.
* testsuite/gas/elf/section12b.d: Likewise.
* testsuite/gas/elf/section13.d: Likewise.
diff --git a/bfd/elf32-visium.c b/bfd/elf32-visium.c
index de81fdca63..76271ce7cd 100644
--- a/bfd/elf32-visium.c
+++ b/bfd/elf32-visium.c
@@ -727,7 +727,6 @@ visium_elf_post_process_headers (bfd *abfd,
struct bfd_link_info *info ATTRIBUTE_UNUSED)
{
Elf_Internal_Ehdr *i_ehdrp = elf_elfheader (abfd);
- i_ehdrp->e_ident[EI_OSABI] = ELFOSABI_STANDALONE;
i_ehdrp->e_ident[EI_ABIVERSION] = 1;
}
@@ -852,6 +851,7 @@ visium_elf_print_private_bfd_data (bfd *abfd, void *ptr)
#define ELF_ARCH bfd_arch_visium
#define ELF_MACHINE_CODE EM_VISIUM
+#define ELF_OSABI ELFOSABI_STANDALONE
#define ELF_MAXPAGESIZE 1
#define TARGET_BIG_SYM visium_elf32_vec
diff --git a/gas/ChangeLog b/gas/ChangeLog
diff --git a/gas/testsuite/gas/elf/section12a.d b/gas/testsuite/gas/elf/section12a.d
index 2b6aa3e8f0..5b764afbe2 100644
--- a/gas/testsuite/gas/elf/section12a.d
+++ b/gas/testsuite/gas/elf/section12a.d
@@ -2,8 +2,9 @@
#as: --no-pad-sections
#readelf: -Sg --wide
#name: mbind sections
-# msp430 and hpux do not support SHF_GNU_MBIND
-#xfail: msp430-*-* *-*-hpux*
+# A number of targets do not support SHF_GNU_MBIND
+#xfail: msp430-*-* visium-*-*
+#xfail: *-*-hpux* *-*-cloudabi
#...
\[[ 0-9]+\] \.mbind\.data[ ]+PROGBITS[ ]+0+0 0+[0-9a-f]+ 0+1 00 WAD 0 0 1
diff --git a/gas/testsuite/gas/elf/section12b.d b/gas/testsuite/gas/elf/section12b.d
index fcbb6974f8..a8406c3057 100644
--- a/gas/testsuite/gas/elf/section12b.d
+++ b/gas/testsuite/gas/elf/section12b.d
@@ -3,8 +3,11 @@
#objdump: -s
#name: mbind section contents
# RX annoyingly reorders the sections so that they do not match the sequence
-# expected below. msp430 and hpux do not support SHF_GNU_MBIND
-#xfail: rx-*-* msp430-*-* *-*-hpux*
+# expected below.
+#xfail: rx-*-*
+# A number of targets do not support SHF_GNU_MBIND
+#xfail: msp430-*-* visium-*-*
+#xfail: *-*-hpux* *-*-cloudabi
#...
Contents of section .mbind.data:
diff --git a/gas/testsuite/gas/elf/section13.d b/gas/testsuite/gas/elf/section13.d
index 9f4fe36f6e..39bc2a376e 100644
--- a/gas/testsuite/gas/elf/section13.d
+++ b/gas/testsuite/gas/elf/section13.d
@@ -1,3 +1,4 @@
#name: mbind sections without SHF_ALLOC
#error_output: section13.l
-#xfail: msp430-*-* *-*-hpux*
+#xfail: msp430-*-* visium-*-*
+#xfail: *-*-hpux* *-*-cloudabi
--
Alan Modra
Australia Development Lab, IBM