This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
PR24827, Linker loops forever if unterminated multi-line comment in script
- From: Alan Modra <amodra at gmail dot com>
- To: binutils at sourceware dot org
- Date: Sat, 20 Jul 2019 10:56:54 +0930
- Subject: PR24827, Linker loops forever if unterminated multi-line comment in script
YY_INPUT returns 0 on end of input, not EOF. Committed.
PR 24827
* ldlex.l (comment): Check for 0 return from input(), not EOF.
diff --git a/ld/ldlex.l b/ld/ldlex.l
index c2abc59571..a5c3ba5999 100644
--- a/ld/ldlex.l
+++ b/ld/ldlex.l
@@ -675,7 +675,7 @@ comment (void)
while (1)
{
c = input();
- while (c != '*' && c != EOF)
+ while (c != '*' && c != 0)
{
if (c == '\n')
lineno++;
@@ -694,7 +694,7 @@ comment (void)
if (c == '\n')
lineno++;
- if (c == EOF)
+ if (c == 0)
{
einfo (_("%F%P: EOF in comment\n"));
break;
--
Alan Modra
Australia Development Lab, IBM