This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH][binutils][Arm] Removed warning for no longer UNPREDICTABLE MVE instructions.
- From: Barnaby Wilks <Barnaby dot Wilks at arm dot com>
- To: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Cc: "nickc at redhat dot com" <nickc at redhat dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>, nd <nd at arm dot com>
- Date: Thu, 18 Jul 2019 13:51:19 +0000
- Subject: Re: [PATCH][binutils][Arm] Removed warning for no longer UNPREDICTABLE MVE instructions.
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=arm.com;dmarc=pass action=none header.from=arm.com;dkim=pass header.d=arm.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C/agHcF3/RwjrqlWEaSMMN5cJS3nVcR54sGRjCTfuZc=; b=T3u2RxpBQlGws6Ml4KOrruM3OZU7YpZJ4VNKb3CRoAqn+8o26VmlBL7J9VOny+djMXqCaKQOQN7SsRsazGPdCylv77M+BT5vBrhaUMHpFYoKaPVIOpNr+OAWuT802v7rbN9kXx/CcivnyfTi/O9vOpOH2AZsMgY3wLSgfl6qA72Dd7ULUcG/z+jjTpG0QiTP85zRBiv7I8V4eEE2A2pShtawS8uxYqNsZmF+ZHQ0bpR+6IEp/i38tdgqhLlKrvI40LQUOaA18iYjpYNooFWo6ieYAFswvVNvMiCLqdgOHAM9JdskkQD/depJCSkqe8iorMyRL6kPEd86VCBXA20ZTw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DW8WDN9hYcDB5KucAz2Tpn+u5dWvU+7o1xefuW2WVlOCdUBwh5jSycnFvRAbcBRy8aFo0vwQB11/OfjA903pNb8xDYMcCKf53zwCB3XTdJa48H4GSJA0LQltg+k5rExeyG5WKPvA9gRiQxNgWFoPonsCwAEnq68T3ZA+yE+hXlCcXxT3izKUjs1MCb2aXdLxMS/LCslw+cBqnp1w3xF79q0CgVG4kKTTy9tvqRlTpPA7G7QhMV5eOgHNTon6k35Mr5uoVbY+VP5ZQm0FRlrCqIDPLlH346aO1fbYhXAWcldYlpqTO1MGk47yLJDWA4MJzqim39ElCK5Ba6IPTY3T7w==
- Original-authentication-results: spf=none (sender IP is ) smtp.mailfrom=Barnaby dot Wilks at arm dot com;
- References: <fa78fbe7-5b38-7590-1be1-e22d1cdad7e8@arm.com>
Hello,
Pinging this patch, could someone have a look at this please, and if it's OK commit for me?
Thanks,
Barney
On 7/8/19 5:38 PM, Barnaby Wilks wrote:
> Hello,
>
> This patch addresses the change in the June Armv8.1-M Mainline specification, that marks certain MVE instructions as
> no longer UNPREDICTABLE when a source operand is the same as a destination operand for a 32-bit element size.
> The instructions that this change apply to are:
> VQDMLADH,
> VQRDMLADH,
> VQDMLSDH,
> VQRDMLSDH
>
> The updated documentation is herehttps://static.docs.arm.com/ddi0553/bh/DDI0553B_h_armv8m_arm.pdf
>
> Fixed this by removing the check for this warning from GAS as well as opcodes.
>
> Added testcases to test that the warning is not generated for the instructions that have a 32-bit element size
> and the same source and destination operand. Also fixed tests that would previously check for this warning.
>
> Cross compiled and regtested on arm-none-eabi and arm-none-linux-gnueabihf.
>
> I don't have write access, so if it's OK then could someone commit on my behalf?
>
> Thanks,
> Barney
>
> gas/ChangeLog:
>
> 2019-06-25 Barnaby Wilks <barnaby.wilks@arm.com>
>
> * config/tc-arm.c (do_mve_vqdmladh): Remove check for UNPREDICTABLE.
> * testsuite/gas/arm/mve-vqdmladh-bad.l: Remove tests.
> * testsuite/gas/arm/mve-vqdmladh-bad.s: Remove tests.
> * testsuite/gas/arm/mve-vqdmladh.d: New tests.
> * testsuite/gas/arm/mve-vqdmladh.s: New tests.
> * testsuite/gas/arm/mve-vqdmlsdh-bad.l: Remove tests.
> * testsuite/gas/arm/mve-vqdmlsdh-bad.s: Remove tests.
> * testsuite/gas/arm/mve-vqdmlsdh.d: New tests.
> * testsuite/gas/arm/mve-vqdmlsdh.s: New tests.
>
> opcodes/ChangeLog:
>
> 2019-06-25 Barnaby Wilks <barnaby.wilks@arm.com>
>
> * arm-dis.c (is_mve_unpredictable): Stop marking some MVE
> instructions as UNPREDICTABLE.
>