This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH binutils 0/4] aarch64: Add STO_AARCH64_VARIANT_PCS support
- From: Szabolcs Nagy <Szabolcs dot Nagy at arm dot com>
- To: "nickc at redhat dot com" <nickc at redhat dot com>, Binutils <binutils at sourceware dot org>
- Cc: nd <nd at arm dot com>
- Date: Mon, 8 Jul 2019 14:25:47 +0000
- Subject: Re: [PATCH binutils 0/4] aarch64: Add STO_AARCH64_VARIANT_PCS support
- References: <72a65558-263b-bb35-5fbb-7d9d5dce1717@arm.com> <83bcabae-1e77-4de3-65bf-8285ef95f78b@redhat.com> <c0cda75f-0e7c-3fd8-ec9e-febab181e7c5@arm.com> <20c27f3f-9244-4e2c-9255-6d07f016d716@arm.com>
On 05/07/2019 15:29, Szabolcs Nagy wrote:
> On 24/05/2019 16:08, Szabolcs Nagy wrote:
>> On 24/05/2019 11:26, Nick Clifton wrote:
>>> Hi Szabolcs,
>>>
>>>> Szabolcs Nagy (4):
>>>> aarch64: add STO_AARCH64_VARIANT_PCS and DT_AARCH64_VARIANT_PCS
>>>> aarch64: handle .variant_pcs directive in gas
>>>> aarch64: override default elf .set handling in gas
>>>> aarch64: handle STO_AARCH64_VARIANT_PCS in bfd
>>>
>>> Patch series approved. (Well modulo the small request for a larger buffer).
>>
>> this is new abi, but since it is required for correctness,
>> i'd like to backport it to the 2.32 release branch after
>> some testing on the master branch.
>>
>
> backported to 2.32 branch.
>
i made a mistake in the backport that can cause build
failure with -werror.
committed the attached patch to fix it.
From 16ba30dcfaa33637fb06bf4e6ff8afe68cb6c810 Mon Sep 17 00:00:00 2001
From: Szabolcs Nagy <szabolcs.nagy@arm.com>
Date: Mon, 8 Jul 2019 13:57:43 +0100
Subject: [PATCH] aarch64: fix DT_AARCH64_VARIANT_PCS handling in readelf
backport commit 13acf03468d1e218c0a980ff6e6adaaac4bb5d1e
failed to copy the changes in get_dynamic_type.
this could cause build failure
binutils/readelf.c:1800:1: warning: 'get_aarch64_dynamic_type' defined but not used [-Wunused-function]
binutils/ChangeLog:
2019-07-08 Szabolcs Nagy <szabolcs.nagy@arm.com>
* readelf.c (get_dynamic_type): Handle EM_AARCH64.
---
binutils/readelf.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/binutils/readelf.c b/binutils/readelf.c
index 28466e0cd7..6b4eb41aee 100644
--- a/binutils/readelf.c
+++ b/binutils/readelf.c
@@ -2180,6 +2180,9 @@ get_dynamic_type (Filedata * filedata, unsigned long type)
switch (filedata->file_header.e_machine)
{
+ case EM_AARCH64:
+ result = get_aarch64_dynamic_type (type);
+ break;
case EM_MIPS:
case EM_MIPS_RS3_LE:
result = get_mips_dynamic_type (type);
--
2.17.1