This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [Patch] [gas][aarch64][SVE2] Fix pmull{t,b} requirement on SVE2-AES
- From: Nick Clifton <nickc at redhat dot com>
- To: Matthew Malcomson <Matthew dot Malcomson at arm dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Cc: Richard Sandiford <Richard dot Sandiford at arm dot com>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, nd <nd at arm dot com>
- Date: Mon, 1 Jul 2019 13:23:38 +0100
- Subject: Re: [Patch] [gas][aarch64][SVE2] Fix pmull{t,b} requirement on SVE2-AES
- References: <AM6PR08MB34141CAF25DDEA8AF2F0DDBFE0FC0@AM6PR08MB3414.eurprd08.prod.outlook.com>
Hi Matthew,
> gas/ChangeLog:
>
> 2019-06-28 Matthew Malcomson <matthew.malcomson@arm.com>
>
> * testsuite/gas/aarch64/illegal-sve2-aes.d: Update tests.
> * testsuite/gas/aarch64/illegal-sve2.l: Update tests.
> * doc/c-aarch64.texi: Add special note of pmull{t,b}
> instructions under the sve2-aes architecture extension.
> * testsuite/gas/aarch64/illegal-sve2.s: Add small size
> pmull{t,b} instructions.
> * testsuite/gas/aarch64/sve2.d: Add small size pmull{t,b}
> disassembly.
> * testsuite/gas/aarch64/sve2.s: Add small size pmull{t,b}
> instructions.
>
> include/ChangeLog:
>
> 2019-06-28 Matthew Malcomson <matthew.malcomson@arm.com>
>
> * opcode/aarch64.h (enum aarch64_insn_class): sve_size_013
> renamed to sve_size_13.
>
> opcodes/ChangeLog:
>
> 2019-06-28 Matthew Malcomson <matthew.malcomson@arm.com>
>
> * aarch64-asm.c (aarch64_encode_variant_using_iclass): Use new
> sve_size_13 icode to account for variant behaviour of
> pmull{t,b}.
> * aarch64-dis-2.c: Regenerate.
> * aarch64-dis.c (aarch64_decode_variant_using_iclass): Use new
> sve_size_13 icode to account for variant behaviour of
> pmull{t,b}.
> * aarch64-tbl.h (OP_SVE_VVV_HD_BS): Add new qualifier.
> (OP_SVE_VVV_Q_D): Add new qualifier.
> (OP_SVE_VVV_QHD_DBS): Remove now unused qualifier.
> (struct aarch64_opcode): Split pmull{t,b} into those requiring
> AES and those not.
>
Approved - please apply.
Cheers
Nick