This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] RISC-V: enable lui relaxation for CODE and MERGE sections.
- From: Jim Wilson <jimw at sifive dot com>
- To: Ilia Diachkov <ilia dot diachkov at optimitech dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Mon, 24 Jun 2019 13:55:26 -0700
- Subject: Re: [PATCH] RISC-V: enable lui relaxation for CODE and MERGE sections.
- References: <36e6a5e5752cb65bc13667c50c3d105c@optimitech.com>
On Fri, Jun 21, 2019 at 11:59 AM Ilia Diachkov
<ilia.diachkov@optimitech.com> wrote:
> This patch enables lui relaxation for CODE and MERGE sections on RISC-V.
> It helps to reduce code size.
I spotted two minor style issues. An extra blank line where we had
the bfd_assert call during testing. And a missing space before an
open paren.
I rewrote the ChangeLog entry. It should describe the actual changes
that are being made, and not the effect of the change. Also, it
should be sentences that start with capital letter.
I did a quick test to make sure I didn't accidentally break it and
then committed and pushed it.
Jim