Re: [PATCH] x86: correct / adjust debug printing

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Mon, Jun 24, 2019 at 8:50 AM Jan Beulich <JBeulich@suse.com> wrote:
>
> For quite some time we've been using combinations of bits for
> specifying various registers in operands and templates. I think it was
> Alan who had indicated that likely the debug printing would need
> adjustment as a result. Here we go.
>
> Accumulator handling for GPRs gets changed to match that for FPU regs.
> For this to work, OPERAND_TYPE_ACC{32,64} get repurposed, with their
> original uses replaced by direct checks of the two bits of interest,
> which is cheaper than operand_type_equal() invocations.
>
> For SIMD registers nothing similar appears to be needed, as respective
> operands get stripped from the (copy of the) template before pt() is
> reached.
>
> The type change on pi() is to silence a compiler diagnostic. Arguably
> its other parameter could also be const-qualified.
>
> gas/
> 2019-06-24  Jan Beulich  <jbeulich@suse.com>
>
>         * tc-i386.c (acc32, acc64): Delete.
>         (pi): Make first parameter pinter-to-const.
>         (type_names): Remove Acc. Add acc8, acc16, acc32, and acc64.
>         (pt): Use operand_type_equal().
>         (match_template): Replace use of acc32.
>         (process_suffix): Replace use of acc64.
>
> opcodes/
> 2019-06-24  Jan Beulich  <jbeulich@suse.com>
>
>         * i386-gen.c (operand_type_init): Correct OPERAND_TYPE_DEBUG
>         entry. Drop OPERAND_TYPE_ACC entry. Add OPERAND_TYPE_ACC8 and
>         OPERAND_TYPE_ACC16 entries. Adjust OPERAND_TYPE_ACC32 and
>         OPERAND_TYPE_ACC64 entries.
>         * i386-init.h: Re-generate.
>

OK.

Thanks.

-- 
H.J.