This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [PATCH] aarch64: remove unnecessary loc_hash_table traversal
- From: Tamar Christina <Tamar dot Christina at arm dot com>
- To: Szabolcs Nagy <Szabolcs dot Nagy at arm dot com>, Binutils <binutils at sourceware dot org>
- Cc: nd <nd at arm dot com>
- Date: Fri, 14 Jun 2019 11:15:12 +0000
- Subject: RE: [PATCH] aarch64: remove unnecessary loc_hash_table traversal
- References: <f1bffc26-e69f-03bd-bf16-0b2aac3494c8@arm.com>
Hi Szabolcs,
The patch also looks OK to me but I'm not a maintainer so you still require approval to commit.
Cheers,
Tamar
> -----Original Message-----
> From: binutils-owner@sourceware.org <binutils-owner@sourceware.org>
> On Behalf Of Szabolcs Nagy
> Sent: Tuesday, June 11, 2019 10:57
> To: Binutils <binutils@sourceware.org>
> Cc: nd <nd@arm.com>
> Subject: [PATCH] aarch64: remove unnecessary loc_hash_table traversal
>
> The loc_hash_table should only contain local ifunc symbols. The current code
> already aborts if there is anything else and for defined ifunc symbols
> elfNN_aarch64_allocate_dynrelocs is a no-op.
>
> bfd/ChangeLog:
>
> 2019-06-11 Szabolcs Nagy <szabolcs.nagy@arm.com>
>
> * elfnn-aarch64.c (elfNN_aarch64_allocate_local_dynrelocs):
> Remove.
> (elfNN_aarch64_size_dynamic_sections): Remove loc_hash_table
> traversal
> with elfNN_aarch64_allocate_local_dynrelocs.