This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] libctf: eschew %zi format specifier
- From: Nick Alcock <nick dot alcock at oracle dot com>
- To: Tom Tromey <tromey at adacore dot com>
- Cc: binutils at sourceware dot org, jose dot marches at oracle dot com, tom dot tromey at adacore dot com
- Date: Wed, 05 Jun 2019 18:06:04 +0100
- Subject: Re: [PATCH] libctf: eschew %zi format specifier
- References: <20190605123826.422222-1-nick.alcock@oracle.com> <87ftooi1ob.fsf@tromey.com>
On 5 Jun 2019, Tom Tromey outgrape:
>>>>>> "Nick" == Nick Alcock <nick.alcock@oracle.com> writes:
>
> Nick> Too many platforms don't support it, and we can always safely use %lu or
> Nick> %li anyway, because the only uses are in debugging output.
>
> Thanks for doing this. I can confirm it fixes the warnings I sent in
> that note. It turns out there were more, because I'd only reported the
> ones that occurred in a file with errors. Full log appended.
I searched for %z uses. I was hoping you might report any other stuff
that happened. :)
I'll squash these.
> The implicit function declaration one looks maybe bad.
No strndup()?! Can't we even rely on POSIX.1-2001? It's old enough to
vote! (I guess I'll have to AC_LIBOBJ a replacement in.)