This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] x86: Enable Intel AVX512 VP2INTERSECT instruction
- From: "Jan Beulich" <JBeulich at suse dot com>
- To: "Lili Cui" <lili dot cui at intel dot com>
- Cc: "Annita Zhang" <annita dot zhang at intel dot com>, "Hongjiu Lu" <hongjiu dot lu at intel dot com>, "Hongtao Liu" <hongtao dot liu at intel dot com>, "Wei3 Xiao" <wei3 dot xiao at intel dot com>,<binutils at sourceware dot org>
- Date: Fri, 31 May 2019 05:45:13 -0600
- Subject: Re: [PATCH] x86: Enable Intel AVX512 VP2INTERSECT instruction
- References: <B1254C1F3D65A641B4143C8E9793D9FD4814A03D@shsmsx102.ccr.corp.intel.com>
>>> On 31.05.19 at 09:05, <lili.cui@intel.com> wrote:
> gas/
>
> 2019-05-27 Igor Tsimbalist <igor.v.tsimbalist@intel.com>
> Lili Cui <lili.cui@intel.com>
>
> * config/tc-i386.c (cpu_arch): Add .avx512_vp2intersect.
> (cpu_noarch): Likewise.
I think there's code missing here: Just like for 4FMAPS and 4VNNIW
insns we warn when the programmer has specified a register not
evenly divisible by 4 (see the ImplicitQuadGroup attribute), you want
to warn here for an odd-numbered mask register. However, rather
than taking the easy route by simply adding another boolean, please
consider converting the existing one to an enum-like attribute, and
simply add another enumerator for the case here. Or quite possibly
a renamed boolean attribute could do - both cases can be easily
distinguished by there being a %k register affected here, but
%[xyz]mm ones there.
> opcodes/
>
> 2019-05-27 Igor Tsimbalist <igor.v.tsimbalist@intel.com>
> Lili Cui <lili.cui@intel.com>
>
> * i386-dis.c (enum): Add PREFIX_EVEX_0F3868, EVEX_W_0F3868_P_3.
> * i386-dis-evex.h (evex_table): Add AVX512_VP2INTERSECT
> instructions.
> * i386-gen.ci (cpu_flag_init): Add CPU_AVX512_VP2INTERSECT_FLAGS,
> CPU_ANY_AVX512_VP2INTERSECT_FLAGS.
> (cpu_flags): Add CpuAVX512_VP2INTERSECT.
> * i386-opc.h (enum): Add CpuAVX512_VP2INTERSECT.
> (i386_cpu_flags): Add cpuavx512_vp2intersect.
> * i386-opc.tbl: Add AVX512_VP2INTERSECT insns.
May I ask that you omit the blank line between the two insns?
Jan