Re: [PATCH v2 08/19] libctf: creation functions

[Szabolcs Nagy <Szabolcs dot Nagy at arm dot com>]

On 17/05/2019 23:09, Nick Alcock wrote:
> --- a/include/ctf-api.h
> +++ b/include/ctf-api.h
> @@ -27,6 +27,7 @@
>  #include <sys/param.h>
>  #include <sys/types.h>
>  #include <ctf.h>
> +#include <zlib.h>

is zlib guaranteed to be available everywhere where
ctf-api.h may be used?

in particular i see

In file included from /S/libctf/ctf-impl.h:25:0,
                 from /S/libctf/ctf-archive.c:20:
/S/libctf/../include/ctf-api.h:30:18: fatal error: zlib.h: No such file or directory
 #include <zlib.h>
                  ^
compilation terminated.
make[2]: *** [ctf-archive.o] Error 1

when the host has no zlib.h
(in that case the binutils internal zlib.h should be used,
ZLIBINC etc should be set up in the Makefile of libctf)