This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 06/19] libctf: hashing
- From: Nick Alcock <nick dot alcock at oracle dot com>
- To: Nick Clifton <nickc at redhat dot com>
- Cc: binutils at sourceware dot org
- Date: Fri, 03 May 2019 20:33:14 +0100
- Subject: Re: [PATCH 06/19] libctf: hashing
- References: <20190430225706.159422-1-nick.alcock@oracle.com> <20190430225706.159422-7-nick.alcock@oracle.com> <0460e204-6113-3dfc-b3b7-dfae809b6f4b@redhat.com>
On 2 May 2019, Nick Clifton uttered the following:
> Hi Nick,
>
>> In the binutils implementation, these are both fairly thin wrappers
>> around libiberty hashtab.
>
> I could not think of anything useful to say about this patch, so this
> is just a comment to let you know that I have looked over it. I think
Thank you for this! Excellent reviews: I'm responding only slowly
because of the volume of changes your comments have generated. :)
15 files changed, 345 insertions(+), 85 deletions(-)
so far... I can only hope that, one day many years from now, I can
review code I've never seen before as well as this.