This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 00/19] libctf, and CTF support for objdump and readelf
- From: Nick Clifton <nickc at redhat dot com>
- To: Nick Alcock <nick dot alcock at oracle dot com>
- Cc: Joseph Myers <joseph at codesourcery dot com>, binutils at sourceware dot org
- Date: Fri, 3 May 2019 13:33:10 +0100
- Subject: Re: [PATCH 00/19] libctf, and CTF support for objdump and readelf
- References: <20190430225706.159422-1-nick.alcock@oracle.com> <alpine.DEB.2.21.1905021508230.4027@digraph.polyomino.org.uk>
Hi Nick,
OK, so I am going to stop my review of this patch series until we have
some answers to a few high level questions/requirements. Specifically:
* Hosting
Is the binutils project the right place for this code ? As Joseph
has already mentioned libctf appears to use code from the elfutils
project, so maybe that would be a better home for libctf ?
* Testing
I did not see a testsuite for the library, nor any additions to
the binutils testsuite for the extensions to objdump and readelf.
I would not be comfortable adding such a large body of code to the
project without some
* Documentation
It would be really good to have the CTF format documented somewhere
(semi) permanent and publicly accessible. It would also be good if
there was a libctf.texi document describing how consumers are expected
to use the library, and, ideally, providing code examples.
* Usefulness
This may be a bit contentious - but is the CTF format actually being
used anywhere, or likely to be used in the near future ? If this is
a project that is just going to be used by a small group, or even just
a single company, then I am worried that the code will just bit rot
away and not be actively maintained.
Cheers
Nick