Re: csky ld testsuite fixes

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Tue, Apr 9, 2019 at 3:22 AM Alan Modra <amodra@gmail.com> wrote:
>
> On Mon, Apr 08, 2019 at 02:24:12PM -0700, H.J. Lu wrote:
> > On Mon, Mar 18, 2019 at 5:12 AM Alan Modra <amodra@gmail.com> wrote:
> > >
> > > Removes some XPASSes for CSKY (and a FAIL for moxie).
> > >
> > >         * testsuite/ld-elf/merge.d: Remove csky from xfails, add moxie.
> > >         * testsuite/ld-elf/pr21884.d: Remove csky from xfails.
> > >         * testsuite/ld-elf/shared.exp: Add csky to list not xfailing pr22374.
> > >         * testsuite/ld-unique/pr21529.d: Remove csky from xfails
> > >
> >
> > csky-elf linker segfaults on these tests.
>
> Not for me on numerous builds since I made those changes.
>

I got:

FAIL: ld-elf/pr21884
FAIL: ld-unique/pr21529

for csky-elf:

(gdb) r -L/export/gnu/import/git/sources/binutils-gdb/ld/testsuite/ld-elf
 -T pr21884.t -o tmpdir/dump tmpdir/pr21884a.o tmpdir/pr21884b.o
Starting program:
/export/build/gnu/tools-build/binutils-cross/build-csky-elf/ld/ld-new
-L/export/gnu/import/git/sources/binutils-gdb/ld/testsuite/ld-elf  -T
pr21884.t -o tmpdir/dump tmpdir/pr21884a.o tmpdir/pr21884b.o
Program received signal SIGSEGV, Segmentation fault.
binary_canonicalize_symtab (abfd=0x522200, alocation=0x522330)
    at /export/gnu/import/git/sources/binutils-gdb/bfd/binary.c:171
171   syms[1].value = sec->size;
(gdb) bt
#0  binary_canonicalize_symtab (abfd=0x522200, alocation=0x522330)
    at /export/gnu/import/git/sources/binutils-gdb/bfd/binary.c:171
#1  0x000000000042e0c7 in bfd_generic_link_read_symbols (
    abfd=abfd@entry=0x522200)
    at /export/gnu/import/git/sources/binutils-gdb/bfd/linker.c:817
#2  0x0000000000430278 in bfd_generic_link_read_symbols (
    abfd=abfd@entry=0x522200)
    at /export/gnu/import/git/sources/binutils-gdb/bfd/linker.c:2178
#3  _bfd_generic_link_output_symbols (output_bfd=output_bfd@entry=0x517030,
    input_bfd=input_bfd@entry=0x522200, info=info@entry=0x50a720 <link_info>,
    psymalloc=psymalloc@entry=0x7fffffffd378)
    at /export/gnu/import/git/sources/binutils-gdb/bfd/linker.c:1982
#4  0x00000000004307c0 in _bfd_generic_final_link (abfd=0x517030,
    info=0x50a720 <link_info>)
    at /export/gnu/import/git/sources/binutils-gdb/bfd/linker.c:1839
#5  0x00000000004191fd in ldwrite ()
    at /export/gnu/import/git/sources/binutils-gdb/ld/ldwrite.c:581
#6  0x0000000000402e66 in main (argc=<optimized out>, argv=<optimized out>)
    at /export/gnu/import/git/sources/binutils-gdb/ld/ldmain.c:456
(gdb)

-- 
H.J.