This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Disable R_X86_64_PLT32 generation as branch marker on Solaris/x86
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: binutils at sourceware dot org
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>
- Date: Wed, 03 Apr 2019 10:50:08 +0200
- Subject: Re: Disable R_X86_64_PLT32 generation as branch marker on Solaris/x86
- References: <yddo95wz2fi.fsf@CeBiTec.Uni-Bielefeld.DE>
Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:
> The fix H.J. implemented for PR gas/22791 in the thread starting at
>
> [PATCH] x86-64: Treat PC32 relocation with branch as PLT32
> https://sourceware.org/ml/binutils/2018-02/msg00065.html
>
> is causing problems on Solaris/x86. The native linker is strongly
> preferred there, and there's no intention of implementing the linker
> optimization he plans there. Besides, the kernel runtime linker,
> otherwise has no need to deal with that reloc at all, and instead of
> adding (possibly even more) workarounds with no benefit, it seems
> appropriate to disable the R_X86_64_PLT32 generation as branch marker on
> Solaris/x86 in the first place.
>
> The patch itself is trivial, the only complication is adapting the
> testsuite. Since I've found no way to have conditional sections in the
> .d files, I've instead used the solution already found elsewhere of
> having separate .d files for the affected tests on Solaris and selecting
> the right one in i386/i386.exp.
>
> Tested on amd64-pc-solaris2.11 and x86_64-pc-linux-gnu without
> regressions. Ok for master (and perhaps the 2.32 branch)?
H.J., any word on this patch? It's been a week...
https://sourceware.org/ml/binutils/2019-03/msg00163.html
Thanks
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University