This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH, BFD, AArch64, x86] Improve warning for --force-bti.
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Sudakshina Das <Sudi dot Das at arm dot com>
- Cc: "nickc at redhat dot com" <nickc at redhat dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>, nd <nd at arm dot com>, Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>
- Date: Tue, 2 Apr 2019 05:31:44 -0700
- Subject: Re: [PATCH, BFD, AArch64, x86] Improve warning for --force-bti.
- References: <27c4cd1c-2126-6e31-3faa-a7c31a4e67e1@arm.com> <fcff06e3-5c32-fcef-b22d-f39e22d51b0a@redhat.com> <d0a68dd5-afcb-0888-61ad-e4ad7e96fc2e@arm.com> <CAMe9rOp6Asa=x-nMwwhmsf8aoUcckAZMnp19SXwCyZ+hG+Kmbw@mail.gmail.com> <8356656c-d50f-8be0-cdfa-8c4c6a4c5313@arm.com>
On Tue, Apr 2, 2019 at 2:05 AM Sudakshina Das <Sudi.Das@arm.com> wrote:
>
> Hi HJ
>
> On 01/04/2019 20:26, H.J. Lu wrote:
> > On Thu, Mar 21, 2019 at 9:25 AM Sudakshina Das <Sudi.Das@arm.com> wrote:
> >>
> >> Hi Nick
> >>
> >> On 21/03/2019 15:14, Nick Clifton wrote:
> >>> Hi Sudi,
> >>>
> >>>> *** bfd/ChangeLog ***
> >>>>
> >>>> 2019-xx-xx Sudakshina Das <sudi.das@arm.com>
> >>>>
> >>>> * elf-bfd.h (struct elf_backend_data): Add argument to
> >>>> merge_gnu_properties.
> >>>> * elf-properties.c (elf_merge_gnu_properties): Add argument to
> >>>> itself and while calling bed->merge_gnu_properties.
> >>>> (elf_merge_gnu_property_list): Update the calls for
> >>>> elf_merge_gnu_properties.
> >>>> * elfnn-aarch64.c (elfNN_aarch64_merge_gnu_properties): Update handling
> >>>> of --force-bti warning and add argument.
> >>>> * elfxx-aarch64.c (_bfd_aarch64_elf_link_setup_gnu_properties): Add
> >>>> warning.
> >>>> * elfxx-x86.c (_bfd_x86_elf_merge_gnu_properties): Add argument.
> >>>> * elfxx-x86.h (_bfd_x86_elf_merge_gnu_properties): Likewise in
> >>>> declaration.
> >>>>
> >>>> *** ld/ChangeLog ***
> >>>>
> >>>> 2019-xx-xx Sudakshina Das <sudi.das@arm.com>
> >>>>
> >>>> * testsuite/ld-aarch64/aarch64-elf.exp: Add new test.
> >>>> * testsuite/ld-aarch64/bti-plt-1.s: Add .ifdef for PAC note section.
> >>>> * testsuite/ld-aarch64/bti-plt-6.d: Update warning.
> >>>> * testsuite/ld-aarch64/bti-plt-7.d: Likewise.
> >>>> * testsuite/ld-aarch64/bti-warn.d: New test.
> >>>
> >>> Approved - please apply.
> >>
> >> Thanks for the approval. Committed as
> >> 4e5391148d51c58785aad637f1a92d47b91b3ae6
> >>
> >> Sudi
> >>
> >
> > Isn't --force-bti for ELF only? Shouldn't it use "-z force-bti"?
>
> Sorry I was not aware of any elf specific meaning given to -z. Is this a
> convention? I can not seem to find any particular documentation for it.
>
This is the convention. See how PARSE_AND_LIST_ARGS_CASE_Z
is used. You can also define PARSE_AND_LIST_OPTIONS to update
"ld --help".
--
H.J.