This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] bfd: xtensa: fix shrink_dynamic_reloc_sections for export-dynamic
- From: Max Filippov <jcmvbkbc at gmail dot com>
- To: "augustine dot sterling at gmail dot com" <augustine dot sterling at gmail dot com>
- Cc: binutils at sourceware dot org
- Date: Fri, 29 Mar 2019 10:40:41 -0700
- Subject: Re: [PATCH] bfd: xtensa: fix shrink_dynamic_reloc_sections for export-dynamic
- References: <20190329010507.22518-1-jcmvbkbc@gmail.com> <CAGSvup9hgmfHGzogyLpkShbbYAV60BCSMn45Q5aNO0Uejxaf5w@mail.gmail.com>
On Thu, Mar 28, 2019 at 9:52 PM augustine.sterling@gmail.com
<augustine.sterling@gmail.com> wrote:
> On Thu, Mar 28, 2019 at 6:05 PM Max Filippov <jcmvbkbc@gmail.com> wrote:
> >
> > shrink_dynamic_reloc_sections must remove PLT entry that was created for
> > an undefined weak symbol in the presence of --export-dynamic option when
> > relaxation coalesces literals pointing to that symbol. This fixes the
> > following assertion:
> >
> > ld: BFD (GNU Binutils) 2.31.1 internal error, aborting at
> > elf32-xtensa.c:3292 in elf_xtensa_finish_dynamic_sections
> >
> > 2019-03-28 Max Filippov <jcmvbkbc@gmail.com>
> > bfd/
> > * elf32-xtensa.c (shrink_dynamic_reloc_sections): Add
> > info->export_dynamic to the conditional.
> >
> > ld/
> > * testsuite/ld-xtensa/relax-undef-weak-pie-export-dynamic.d: New
> > test definition.
> > * testsuite/ld-xtensa/xtensa.exp
> > (relax-undef-weak-pie-export-dynamic): Add new test.
>
>
> Looks good.
Applied to master.
--
Thanks.
-- Max