This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
PR24337, segfault in _bfd_elf_rela_local_sym
- From: Alan Modra <amodra at gmail dot com>
- To: binutils at sourceware dot org
- Date: Fri, 15 Mar 2019 20:03:55 +1030
- Subject: PR24337, segfault in _bfd_elf_rela_local_sym
PR 24337
* elf.c (_bfd_elf_rela_local_sym): Don't segfault on NULL sec.
(_bfd_elf_rel_local_sym): Likewise.
diff --git a/bfd/elf.c b/bfd/elf.c
index 73fb86971f..585bf3ca7d 100644
--- a/bfd/elf.c
+++ b/bfd/elf.c
@@ -11822,9 +11822,10 @@ _bfd_elf_rela_local_sym (bfd *abfd,
asection *sec = *psec;
bfd_vma relocation;
- relocation = (sec->output_section->vma
- + sec->output_offset
- + sym->st_value);
+ relocation = sym->st_value;
+ if (sec == NULL)
+ return relocation;
+ relocation += sec->output_section->vma + sec->output_offset;
if ((sec->flags & SEC_MERGE)
&& ELF_ST_TYPE (sym->st_info) == STT_SECTION
&& sec->sec_info_type == SEC_INFO_TYPE_MERGE)
@@ -11858,7 +11859,7 @@ _bfd_elf_rel_local_sym (bfd *abfd,
{
asection *sec = *psec;
- if (sec->sec_info_type != SEC_INFO_TYPE_MERGE)
+ if (sec == NULL || sec->sec_info_type != SEC_INFO_TYPE_MERGE)
return sym->st_value + addend;
return _bfd_merged_section_offset (abfd, psec,
--
Alan Modra
Australia Development Lab, IBM