This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH 5/7] [gas] dwarf2: Use octets for .debug_string offsets
- From: Christian Eggers <ceggers at gmx dot de>
- To: binutils at sourceware dot org
- Cc: Christian Eggers <ceggers at gmx dot de>
- Date: Sun, 10 Mar 2019 19:21:56 +0100
- Subject: [PATCH 5/7] [gas] dwarf2: Use octets for .debug_string offsets
- References: <20190310182158.23705-1-ceggers@gmx.de>
Like other dwarf2 offsets, also the string offsets in the .debug_info
section which points into the .debug_str section must be expressed in
octets instead of bytes.
This change should not affect existing targets as all targets currently
using DWARF2 have 8 bit per byte.
Signed-off-by: Christian Eggers <ceggers@gmx.de>
---
gas/ChangeLog | 5 +++++
gas/dwarf2dbg.c | 6 +++---
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/gas/ChangeLog b/gas/ChangeLog
index 4cb2702ab2..2d7dabc299 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,8 @@
+2019-03-10 Christian Eggers <ceggers@gmx.de>
+
+ * dwarf2dbg.c: Use octets for .debug_string pointers.
+ (out_debug_str): symbol_temp_new_now() --> symbol_temp_new_now_octets()
+
2019-03-10 Christian Eggers <ceggers@gmx.de>
* dwarf2dbg.c: Use octets for .debug_line prologue.
diff --git a/gas/dwarf2dbg.c b/gas/dwarf2dbg.c
index 896a8f125a..d469138576 100644
--- a/gas/dwarf2dbg.c
+++ b/gas/dwarf2dbg.c
@@ -2103,7 +2103,7 @@ out_debug_str (segT str_seg, symbolS **name_sym, symbolS **comp_dir_sym,
on the command line, so assume files[1] is the main input file.
We're not supposed to get called unless at least one line number
entry was emitted, so this should always be defined. */
- *name_sym = symbol_temp_new_now ();
+ *name_sym = symbol_temp_new_now_octets ();
if (files_in_use == 0)
abort ();
if (files[1].dir)
@@ -2125,14 +2125,14 @@ out_debug_str (segT str_seg, symbolS **name_sym, symbolS **comp_dir_sym,
memcpy (p, files[1].filename, len);
/* DW_AT_comp_dir */
- *comp_dir_sym = symbol_temp_new_now ();
+ *comp_dir_sym = symbol_temp_new_now_octets ();
comp_dir = remap_debug_filename (getpwd ());
len = strlen (comp_dir) + 1;
p = frag_more (len);
memcpy (p, comp_dir, len);
/* DW_AT_producer */
- *producer_sym = symbol_temp_new_now ();
+ *producer_sym = symbol_temp_new_now_octets ();
sprintf (producer, "GNU AS %s", VERSION);
len = strlen (producer) + 1;
p = frag_more (len);
--
2.16.4