This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH]Always skip only 1 byte for CIE version 1's return address register.


Hi Andreas,

Thanks! I had noticed it after sending it out and will update it in the patch before committing.

Regards,
Tamar

> -----Original Message-----
> From: Andreas Schwab <schwab@linux-m68k.org>
> Sent: Friday, March 1, 2019 11:01
> To: Tamar Christina <Tamar.Christina@arm.com>
> Cc: binutils@sourceware.org; nd <nd@arm.com>
> Subject: Re: [PATCH]Always skip only 1 byte for CIE version 1's return address
> register.
> 
> On Feb 28 2019, Tamar Christina <Tamar.Christina@arm.com> wrote:
> 
> > @@ -2005,12 +2005,16 @@ _bfd_elf_write_section_eh_frame (bfd *abfd,
> >  	      extra_data = extra_augmentation_data_bytes (ent);
> >
> >  	      /* Skip length, id and version.  */
> > -	      buf += 9;
> > +	      buf += 8;
> > +	      version = (unsigned int)(*(char*) buf++);
> 
> The comment no longer matches.
> 
> Andreas.
> 
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
> "And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]