This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Use new Darwin operating system names
- From: Nick Clifton <nickc at redhat dot com>
- To: Kevin Buettner <kevinb at redhat dot com>, binutils at sourceware dot org, Saagar Jha <saagar at saagarjha dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 15 Feb 2019 10:02:17 +0000
- Subject: Re: [PATCH] Use new Darwin operating system names
- References: <E1F08FC0-B475-4855-AD95-F65515838599@saagarjha.com> <20190214191325.2354ddbc@f29-4.lan>
Hi Saagar,
>
> 1) This entry should go in include/ChangeLog, so you don't need to
> have the include/ prefix.
>
> 2) Please adjust it to indicate that only the comments are affected.
> Like this, perhaps:
>
> * mach-o/loader.h: Use new OS names in comments.
>
> Otherwise, it looks good to me.
>
> I wish I could tell you to check this in, but I think that the
> binutils maintainers will need to approve this change. I've added
> binutils@sourceware.org to the "To:" header in my reply.
It is fine with the binutils too. So please apply with the changes
that Kevin has outlined.
Cheers
Nick