This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] xtensa: gas: don't keep relocations for constants
- From: Romain Naour <romain dot naour at gmail dot com>
- To: Max Filippov <jcmvbkbc at gmail dot com>, Nick Clifton <nickc at redhat dot com>
- Cc: binutils at sourceware dot org, Sterling Augustine <augustine dot sterling at gmail dot com>, Eric Tsai <erictsai at cadence dot com>, linux-xtensa at linux-xtensa dot org
- Date: Sun, 3 Feb 2019 12:20:50 +0100
- Subject: Re: [PATCH] xtensa: gas: don't keep relocations for constants
- References: <20190128092137.22150-1-jcmvbkbc@gmail.com> <be4f2ffc-3ce8-175b-2910-21174a407113@redhat.com> <CAMo8BfKSGOnp8fEJaf9D4cmYZGojijC4Vj=x2iDnzLAFb1jNcQ@mail.gmail.com> <fdc601bd-27dc-70b1-9212-7ae1511bac15@redhat.com> <CAMo8BfJraw+Y7A_Gs_mV0E0FvK=cA9yTLRs2U_kwV2fNSpo3Sw@mail.gmail.com> <f3ab67d9-3c5f-05ac-0cfa-8fa19b9c2ddb@gmail.com>
Hi Max,
Le 02/02/2019 à 18:59, Romain Naour a écrit :
> Hi Max,
>
> Le 29/01/2019 à 20:25, Max Filippov a écrit :
>> On Tue, Jan 29, 2019 at 4:56 AM Nick Clifton <nickc@redhat.com> wrote:
>>>>>> * config/tc-xtensa.c (md_apply_fix): Mark fixups for constant
>>>>>> symbols as done in md_apply_fix.
>>>>>> * testsuite/gas/all/forward.d: Don't XFAIL for xtensa.
>>>>>
>>>>> Approved - please apply.
>>>>
>>>> Thanks, applied to master.
>>>> This is a fix for regression in 2.32 candidate, is it OK for
>>>> binutils-2_32-branch?
>>>
>>> Yes - please apply there as well.
>>
>> Thanks, applied.
>
I tested the patch using Binutils 2.32, the toolchain build is ok but the kernel
doesn't boot.
https://gitlab.com/kubu93/toolchains-builder/-/jobs/155355484
I tested the with the same config but using Binutils 2.31.1 and the kernel boot.
Can you have a look?
Best regards,
Romain
>
>>
>> -- Max
>>
>