This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 1/4] S12Z: GAS: Disallow immediate destination operands
- From: John Darrington <john at darrington dot wattle dot id dot au>
- To: Nick Clifton <nickc at redhat dot com>
- Cc: John Darrington <john at darrington dot wattle dot id dot au>, binutils at sourceware dot org
- Date: Fri, 1 Feb 2019 13:51:44 +0100
- Subject: Re: [PATCH 1/4] S12Z: GAS: Disallow immediate destination operands
- References: <20190131180442.31410-1-john@darrington.wattle.id.au> <3bda1769-c054-23b0-9f3b-31f2aa0ffdd3@redhat.com>
On Fri, Feb 01, 2019 at 10:48:57AM +0000, Nick Clifton wrote:
Why does this function return an int instead of a bfd_boolean ?
> static int
> -reg_opr (const struct instruction *insn, int allowed_regs)
> +reg_opr (const struct instruction *insn, int allowed_regs,
> + bool immediate_ok)
> {
In fact ... it seems that there are a whole bunch of functions
in tc-s12z.c that ought to be returning booleans. Just an idea
for a clean-up patch...
You're right. I'll prepare such a patch in the next few days.
J'