This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix GCC9 warning on elf32-arm.c:elf32_arm_final_link_relocate

From: Sergio Durigan Junior <sergiodj at redhat dot com>
To: Nick Clifton <nickc at redhat dot com>
Cc: binutils at sourceware dot org
Date: Mon, 28 Jan 2019 10:52:06 -0500
Subject: Re: [PATCH] Fix GCC9 warning on elf32-arm.c:elf32_arm_final_link_relocate
References: <20190121204113.22669-1-sergiodj@redhat.com> <87ef8xqyj7.fsf@redhat.com> <12707fd8-8b64-fb10-4599-585286652f5f@redhat.com>

On Monday, January 28 2019, Nick Clifton wrote:

> Hi Sergio,
>
>> Ping.
>
> Sorry - I meant to reply last week, but got distracted.

No problem.

>>> The fix is (apparently) simple: instead of using 'labs', we should use
>>> 'llabs', since we're passing a 'bfd_signed_vma' to it, which is at
>>> least a 'long long int', as far as I have checked.  This is what this
>>> patch does.
>>>
>>> OK to apply?
>
> Yes - approved - please apply.

Thanks, pushed.

453f8e1e4918171bc12e4d03aab7ee8360dfcfef

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

References:
- [PATCH] Fix GCC9 warning on elf32-arm.c:elf32_arm_final_link_relocate
  - From: Sergio Durigan Junior
- Re: [PATCH] Fix GCC9 warning on elf32-arm.c:elf32_arm_final_link_relocate
  - From: Sergio Durigan Junior
- Re: [PATCH] Fix GCC9 warning on elf32-arm.c:elf32_arm_final_link_relocate
  - From: Nick Clifton

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]